[Doc] Added permissions for GCP file events #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borremosch-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
reviewed
Jan 24, 2025
nkvuong
reviewed
Jan 24, 2025
nkvuong
reviewed
Jan 24, 2025
nkvuong
reviewed
Jan 24, 2025
borremosch-db
force-pushed
the
add-storage-credential-file-events-permissions-gcp
branch
from
1e02973 to
cd6743d
Compare
|
@nkvuong I finally had time to e2e test this. I have changed the PR to modify the external location setup instead of the metastore setup. I'll follow up on that later if necessary. Please have another look |
borremosch-db
changed the title
nkvuong
changed the title
|
@borremosch-db 2 more things please:
|
borremosch-db
force-pushed
the
add-storage-credential-file-events-permissions-gcp
branch
from
9c4e599 to
c8b687b
Compare
|
@nkvuong you're right, added changelog and the service agent role binding. Please have another look! |
nkvuong
approved these changes
Mar 17, 2025
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Apr 1, 2025
## Release v1.71.0 ### New Features and Improvements * Mark GKE-related fields for `databricks_mws_workspaces` and `databricks_mws_networks` as deprecated([#4531](#4531)). * Add support for `CAN_VIEW` permission level in `databricks_permissions`, which can be assigned to `databricks_sql_endpoint` ([#4464](#4464)). * Add support for `aws-us-gov-dod` (AWS Govcloud DoD shard) ([#4594](5ac0111)) ### Bug Fixes * Recreate `databricks_access_control_rule_set` when the `name` changes ([#4572](#4572)). * Avoid timeouts during `databricks_mount` state refresh and creation ([#4590](#4590)). ### Documentation * Improve documentation for `databricks_access_control_rule_set` ([#4580](#4580)). * Correct `first_on_demand` documentation for `aws_attributes` in `databricks_cluster`. * Added file events permissions to GCP external location documentation. ([#4415](#4415)). * Improve description of `metric` field in `databricks_job` resource [#4595](#4595) ### Exporter * Add support for special selectors in `-listing` and `-services` [#4573](#4573) * Fix incorrect reference to model serving endpoint [#4588](#4588) * Allow the selective export of `databricks_mws_permission_assignment`, and change its service name to `idfed` instead of `access` ([#4571](#4571)) * Fix panic caused by incorrect values in the cluster policies ([#4585](#4585)) ### Internal Changes * Bump Go SDK version to 0.61.0 ([#4602](#4602))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added permissions for GCP file events. As it stands, this is a docs only change, similar to the PR for Azure. I'm wondering if it's possible and/or desirable to wrap the created role into a custom terraform resource as is the case with AWS. Whatever we end up with, I'll need to e2e test this before merging.
Tests
make testrun locallydocs/folderinternal/acceptance