-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add CAN_VIEW
permission for SQL warehouse
#4464
Conversation
CAN_MONITOR_ONLY
permission for SQL warehouse
This is a private preview feature so it's failing on integration tests |
Yes it's in private preview now, but going on public preview soon. I can hold off the PR until PuPr. |
Head branch was pushed to by a user without write access
CAN_MONITOR_ONLY
permission for SQL warehouseCAN_VIEW
permission for SQL warehouse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the new "CAN_VIEW" permission level for SQL warehouses.
- Added "CAN_VIEW" permission in permission_definitions.go.
- Updated acceptance tests to include "CAN_VIEW" in test cases.
- Updated documentation and changelog to reflect the new permission support.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
permissions/permission_definitions.go | Introduces "CAN_VIEW" with isManagementPermission set to false. |
NEXT_CHANGELOG.md | Documents support for "CAN_VIEW" permission. |
permissions/permissions_test.go | Updates tests to include "CAN_VIEW" permission level. |
docs/resources/permissions.md | Updates documentation on SQL warehouse permissions. |
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
## Release v1.71.0 ### New Features and Improvements * Mark GKE-related fields for `databricks_mws_workspaces` and `databricks_mws_networks` as deprecated([#4531](#4531)). * Add support for `CAN_VIEW` permission level in `databricks_permissions`, which can be assigned to `databricks_sql_endpoint` ([#4464](#4464)). * Add support for `aws-us-gov-dod` (AWS Govcloud DoD shard) ([#4594](5ac0111)) ### Bug Fixes * Recreate `databricks_access_control_rule_set` when the `name` changes ([#4572](#4572)). * Avoid timeouts during `databricks_mount` state refresh and creation ([#4590](#4590)). ### Documentation * Improve documentation for `databricks_access_control_rule_set` ([#4580](#4580)). * Correct `first_on_demand` documentation for `aws_attributes` in `databricks_cluster`. * Added file events permissions to GCP external location documentation. ([#4415](#4415)). * Improve description of `metric` field in `databricks_job` resource [#4595](#4595) ### Exporter * Add support for special selectors in `-listing` and `-services` [#4573](#4573) * Fix incorrect reference to model serving endpoint [#4588](#4588) * Allow the selective export of `databricks_mws_permission_assignment`, and change its service name to `idfed` instead of `access` ([#4571](#4571)) * Fix panic caused by incorrect values in the cluster policies ([#4585](#4585)) ### Internal Changes * Bump Go SDK version to 0.61.0 ([#4602](#4602))
Changes
Add CAN_VIEW permission for SQL warehouse
Tests
Locally installed and tested. See the following output:
make test
run locallydocs/
folderinternal/acceptance