Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add multipart permissions to databricks_aws_unity_catalog_policy data source #4440

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 28, 2025

Changes

To support uploading of big files to UC volumes, etc. we need to give permissions to perform operations related to AWS multipart uploads APIs.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners January 28, 2025 07:46
@alexott alexott requested review from parthban-db and removed request for a team January 28, 2025 07:46
@alexott alexott temporarily deployed to test-trigger-is January 28, 2025 07:46 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 28, 2025 07:47 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 28, 2025 07:55 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 28, 2025 07:55 — with GitHub Actions Inactive
…policy` data source

To support uploading of big files to UC volumes, etc. we need to give permissions to
perform operations related to AWS multipart uploads APIs.
@alexott alexott force-pushed the feature/aws-uc-multipart-permissions branch from 98ba19b to d77abc2 Compare January 31, 2025 18:55
@alexott alexott temporarily deployed to test-trigger-is January 31, 2025 18:55 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 31, 2025 18:55 — with GitHub Actions Inactive
@alexott alexott requested a review from mgyucht February 6, 2025 13:52
Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just formatting changes

Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you address the tabs :)

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4440
  • Commit SHA: ba853ae10f03af53723cf98ca66bcfb531e8815c

Checks will be approved automatically on success.

@alexott alexott added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 9889a94 Feb 12, 2025
13 checks passed
@alexott alexott deleted the feature/aws-uc-multipart-permissions branch February 12, 2025 12:37
deco-sdk-tagging bot added a commit that referenced this pull request Feb 13, 2025
## Release v1.66.0

### New Features and Improvements

 * Add multipart permissions to `databricks_aws_unity_catalog_policy` data source ([#4440](#4440)).

### Bug Fixes
 * Fixed an issue where reordering objects in a (pluginfw) Share wouldn’t update properly unless other changes were made ([#4481](#4481)).

 * Suppress `options.pem_private_key_expiration_epoch_sec` attribute for databricks_connection ([#4474](#4474)).

### Documentation

 * Add an example for Databricks Apps permissions ([#4475](#4475)).
 * Add explanation of timeouts to the troubleshooting guide ([#4482](#4482)).
 * Clarify that `databricks_token` and `databricks_obo_token` could be used only with workspace-level provider ([#4480](#4480)).

### Exporter

 * Refactor UC, SQL and SCIM objects into separate files ([#4477](#4477)).

### Internal Changes

 * Remove incorrectly working integration test `TestAccLibraryUpdateTransitionFromPluginFw` ([#4487](#4487)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants