Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Share Reordering Issue #4481

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[Fix] Share Reordering Issue #4481

merged 1 commit into from
Feb 10, 2025

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Feb 10, 2025

Changes

This PR fixes an issue where reordering objects in a (pluginfw) Share would fail unless other changes were made to the objects. The bug caused the new order to be ignored if no additional modifications were present. With this fix, reordering now correctly updates the Share, whether or not other changes are made.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@rauchy rauchy requested review from a team as code owners February 10, 2025 11:56
@rauchy rauchy requested review from parthban-db and removed request for a team February 10, 2025 11:56
@rauchy rauchy temporarily deployed to test-trigger-is February 10, 2025 11:56 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is February 10, 2025 11:56 — with GitHub Actions Inactive
@rauchy rauchy force-pushed the fix-share-reordering branch from 18a2625 to 31a0bd2 Compare February 10, 2025 11:57
@databricks databricks deleted a comment from github-actions bot Feb 10, 2025
@rauchy rauchy temporarily deployed to test-trigger-is February 10, 2025 11:57 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is February 10, 2025 11:58 — with GitHub Actions Inactive
@rauchy rauchy requested a review from mgyucht February 10, 2025 12:13
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rauchy rauchy force-pushed the fix-share-reordering branch from 31a0bd2 to f97a496 Compare February 10, 2025 13:56
@rauchy rauchy temporarily deployed to test-trigger-is February 10, 2025 13:56 — with GitHub Actions Inactive
@rauchy rauchy enabled auto-merge February 10, 2025 13:57
@rauchy rauchy temporarily deployed to test-trigger-is February 10, 2025 13:57 — with GitHub Actions Inactive
@rauchy rauchy force-pushed the fix-share-reordering branch from f97a496 to 31a0bd2 Compare February 10, 2025 14:12
@rauchy rauchy temporarily deployed to test-trigger-is February 10, 2025 14:12 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4481
  • Commit SHA: 31a0bd27544ccd141ea5afe4581bc246c87c3c41

Checks will be approved automatically on success.

@rauchy rauchy temporarily deployed to test-trigger-is February 10, 2025 14:12 — with GitHub Actions Inactive
@rauchy rauchy added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit d4d3422 Feb 10, 2025
24 checks passed
@rauchy rauchy deleted the fix-share-reordering branch February 10, 2025 18:39
deco-sdk-tagging bot added a commit that referenced this pull request Feb 13, 2025
## Release v1.66.0

### New Features and Improvements

 * Add multipart permissions to `databricks_aws_unity_catalog_policy` data source ([#4440](#4440)).

### Bug Fixes
 * Fixed an issue where reordering objects in a (pluginfw) Share wouldn’t update properly unless other changes were made ([#4481](#4481)).

 * Suppress `options.pem_private_key_expiration_epoch_sec` attribute for databricks_connection ([#4474](#4474)).

### Documentation

 * Add an example for Databricks Apps permissions ([#4475](#4475)).
 * Add explanation of timeouts to the troubleshooting guide ([#4482](#4482)).
 * Clarify that `databricks_token` and `databricks_obo_token` could be used only with workspace-level provider ([#4480](#4480)).

### Exporter

 * Refactor UC, SQL and SCIM objects into separate files ([#4477](#4477)).

### Internal Changes

 * Remove incorrectly working integration test `TestAccLibraryUpdateTransitionFromPluginFw` ([#4487](#4487)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants