-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Share Reordering Issue #4481
Merged
Merged
+41
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18a2625
to
31a0bd2
Compare
mgyucht
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
31a0bd2
to
f97a496
Compare
f97a496
to
31a0bd2
Compare
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Feb 13, 2025
## Release v1.66.0 ### New Features and Improvements * Add multipart permissions to `databricks_aws_unity_catalog_policy` data source ([#4440](#4440)). ### Bug Fixes * Fixed an issue where reordering objects in a (pluginfw) Share wouldn’t update properly unless other changes were made ([#4481](#4481)). * Suppress `options.pem_private_key_expiration_epoch_sec` attribute for databricks_connection ([#4474](#4474)). ### Documentation * Add an example for Databricks Apps permissions ([#4475](#4475)). * Add explanation of timeouts to the troubleshooting guide ([#4482](#4482)). * Clarify that `databricks_token` and `databricks_obo_token` could be used only with workspace-level provider ([#4480](#4480)). ### Exporter * Refactor UC, SQL and SCIM objects into separate files ([#4477](#4477)). ### Internal Changes * Remove incorrectly working integration test `TestAccLibraryUpdateTransitionFromPluginFw` ([#4487](#4487)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue where reordering objects in a (pluginfw) Share would fail unless other changes were made to the objects. The bug caused the new order to be ignored if no additional modifications were present. With this fix, reordering now correctly updates the Share, whether or not other changes are made.
Tests
make test
run locallydocs/
folderinternal/acceptance