Skip to content

[Feature] Add multipart permissions to databricks_aws_unity_catalog_policy data source #4440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 12, 2025
Merged

[Feature] Add multipart permissions to databricks_aws_unity_catalog_policy data source #4440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3170de8
[Feature] Add multipart permissions to `databricks_aws_unity_catalog_…
alexott Jan 28, 2025
044f9b2
Fix all tests
alexott Jan 28, 2025
d77abc2
Add changelog entry
alexott Jan 31, 2025
a2317bf
Apply suggestions from code review
alexott Feb 11, 2025
32813f4
Merge branch 'main' into feature/aws-uc-multipart-permissions
alexott Feb 11, 2025
ba853ae
Merge branch 'main' into feature/aws-uc-multipart-permissions
alexott Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@

### New Features and Improvements

* Support updating `options` in `databricks_catalog` ([#4476](https://github.com/databricks/terraform-provider-databricks/pull/4476)).
* Increase `databricks_library` timeout from 15m to 30m.
* Add multipart permissions to `databricks_aws_unity_catalog_policy` data source ([#4440](https://github.com/databricks/terraform-provider-databricks/pull/4440)).

### Bug Fixes
* Fixed an issue where reordering objects in a (pluginfw) Share wouldn’t update properly unless other changes were made ([#4481](https://github.com/databricks/terraform-provider-databricks/pull/4481)).
Expand Down
4 changes: 4 additions & 0 deletions aws/data_aws_unity_catalog_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ func generateReadContext(ctx context.Context, d *schema.ResourceData, m *common.
"s3:DeleteObject",
"s3:ListBucket",
"s3:GetBucketLocation",
// Multipart uploads support
"s3:ListBucketMultipartUploads",
"s3:ListMultipartUploadParts",
"s3:AbortMultipartUpload",
},
Resources: []string{
fmt.Sprintf("arn:%s:s3:::%s/*", awsPartition, bucket),
Expand Down
20 changes: 16 additions & 4 deletions aws/data_aws_unity_catalog_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ func TestDataAwsUnityCatalogPolicy(t *testing.T) {
"s3:PutObject",
"s3:DeleteObject",
"s3:ListBucket",
"s3:GetBucketLocation"
"s3:GetBucketLocation",
"s3:ListBucketMultipartUploads",
"s3:ListMultipartUploadParts",
"s3:AbortMultipartUpload"
],
"Resource": [
"arn:aws:s3:::databricks-bucket/*",
Expand Down Expand Up @@ -146,7 +149,10 @@ func TestDataAwsUnityCatalogPolicyFullKms(t *testing.T) {
"s3:PutObject",
"s3:DeleteObject",
"s3:ListBucket",
"s3:GetBucketLocation"
"s3:GetBucketLocation",
"s3:ListBucketMultipartUploads",
"s3:ListMultipartUploadParts",
"s3:AbortMultipartUpload"
],
"Resource": [
"arn:aws:s3:::databricks-bucket/*",
Expand Down Expand Up @@ -258,7 +264,10 @@ func TestDataAwsUnityCatalogPolicyWithoutKMS(t *testing.T) {
"s3:PutObject",
"s3:DeleteObject",
"s3:ListBucket",
"s3:GetBucketLocation"
"s3:GetBucketLocation",
"s3:ListBucketMultipartUploads",
"s3:ListMultipartUploadParts",
"s3:AbortMultipartUpload"
],
"Resource": [
"arn:aws:s3:::databricks-bucket/*",
Expand Down Expand Up @@ -361,7 +370,10 @@ func TestDataAwsUnityCatalogPolicyPartionGov(t *testing.T) {
"s3:PutObject",
"s3:DeleteObject",
"s3:ListBucket",
"s3:GetBucketLocation"
"s3:GetBucketLocation",
"s3:ListBucketMultipartUploads",
"s3:ListMultipartUploadParts",
"s3:AbortMultipartUpload"
],
"Resource": [
"arn:aws-us-gov:s3:::databricks-bucket/*",
Expand Down
Loading