Skip to content

Feat/reduced ssn api #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2025
Merged

Feat/reduced ssn api #541

merged 3 commits into from
Feb 19, 2025

Conversation

jusdino
Copy link
Collaborator

@jusdino jusdino commented Feb 11, 2025

Description List

  • Removed full SSN from provider/license API objects
  • Removed full sun from provider/license db records
  • Removed access to SSN table to resources that no-longer need it
  • Removed deprecated 'read' permission from API
  • Created migration for existing provider/license data
  • Created migration for existing staff users

Closes #391

@jusdino jusdino marked this pull request as draft February 11, 2025 20:02
@jusdino
Copy link
Collaborator Author

jusdino commented Feb 11, 2025

Note: We should wait until #535 is merged before pushing this forward, as it will need to be rebased on development.

@jusdino jusdino force-pushed the feat/reduced-ssn-api branch from c46e009 to 4e951ad Compare February 13, 2025 21:07
@jusdino jusdino marked this pull request as ready for review February 13, 2025 21:07
landonshumway-ia
landonshumway-ia suggested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@landonshumway-ia landonshumway-ia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one tiny nit

@landonshumway-ia
Copy link
Collaborator

@jlkravitz This is ready for your review. Thanks

jlkravitz
jlkravitz previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise looks good!

@jusdino
Copy link
Collaborator Author

jusdino commented Feb 18, 2025

@jlkravitz , comment addressed :)

jlkravitz
jlkravitz approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen Good to merge this one!

@isabeleliassen isabeleliassen self-requested a review February 19, 2025 18:36
@isabeleliassen isabeleliassen merged commit 7d56f60 into csg-org:development Feb 19, 2025
2 checks passed
@jusdino jusdino deleted the feat/reduced-ssn-api branch February 28, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlkravitz jlkravitz jlkravitz approved these changes

@isabeleliassen isabeleliassen isabeleliassen approved these changes

@landonshumway-ia landonshumway-ia landonshumway-ia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduced SSN API footprint (backend)
4 participants
@jusdino @landonshumway-ia @jlkravitz @isabeleliassen