-
Notifications
You must be signed in to change notification settings - Fork 5
Feat/get one ssn #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/get one ssn #535
Conversation
backend/compact-connect/lambdas/python/common/cc_common/data_model/data_client.py
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/provider-data-v1/handlers/providers.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/stacks/api_stack/v1_api/query_providers.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/common/cc_common/utils.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/staff-user-pre-token/user_data.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/stacks/api_stack/v1_api/query_providers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this looks much better with the CCPermissionsAction enum
@jlkravitz This should be ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Appreciate the attention to detail when it comes to SSN access. A few comments/questions.
backend/compact-connect/lambdas/python/common/tests/function/test_data_client.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/provider-data-v1/handlers/providers.py
Show resolved
Hide resolved
...mpact-connect/lambdas/python/provider-data-v1/tests/function/test_handlers/test_providers.py
Show resolved
Hide resolved
@isabeleliassen This is good to merge. The failed test is due to an out-of-date dependency that has been fixed in |
@jlkravitz we'll need your approval review as well! |
Description List
Closes #392