refactor: rewrite ClickListener
#18962
Merged
+76
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18962 +/- ##
==========================================
- Coverage 84.88% 84.85% -0.04%
==========================================
Files 396 395 -1
Lines 14512 14487 -25
Branches 4738 4713 -25
==========================================
- Hits 12319 12293 -26
- Misses 2044 2046 +2
+ Partials 149 148 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gururajj77
approved these changes
Apr 7, 2025
kennylam
approved these changes
Apr 8, 2025
Merged
via the queue into
carbon-design-system:main
with commit Apr 8, 2025
901e319
54 of 55 checks passed
|
Hey there! v11.80.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18960
Rewrote
ClickListener.Changelog
Changed
ClickListenerto a functional component.ClickListenerin TypeScript.Testing / Reviewing
yarn test packages/reactClickListeneris only used in one file which makes me question whether it's necessary or if there's something else that should be used instead. Maybe in another pull request, I could look into substitutingClickListenerforuseOutsideClick.useOutsideClickshould probably be ported/rewritten in TypeScript first and that can't happen until #18950 moves forward.