-
Notifications
You must be signed in to change notification settings - Fork 1.9k
refactor: rewrite useEvent
and useWindowEvent
in typescript
#18950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rewrite useEvent
and useWindowEvent
in typescript
#18950
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18950 +/- ##
==========================================
- Coverage 84.91% 84.88% -0.03%
==========================================
Files 391 390 -1
Lines 14490 14467 -23
Branches 4742 4774 +32
==========================================
- Hits 12304 12281 -23
Misses 2037 2037
Partials 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bd0e13f
Closes #18948
Rewrote
useEvent
anduseWindowEvent
in TypeScript.Changelog
Changed
useEvent
anduseWindowEvent
in TypeScript.Testing / Reviewing
yarn test packages/react