Skip to content

refactor: rewrite useEvent and useWindowEvent in typescript #18950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

adamalston
Copy link
Contributor

Closes #18948

Rewrote useEvent and useWindowEvent in TypeScript.

Changelog

Changed

  • Rewrote useEvent and useWindowEvent in TypeScript.

Testing / Reviewing

yarn test packages/react

Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 24d2345
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67e6aac5eafe470008819d5f
😎 Deploy Preview https://deploy-preview-18950--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 93654f9
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67f5bd1662c73700087f62ed
😎 Deploy Preview https://deploy-preview-18950--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 93654f9
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67f5bd16330a42000801bb5c
😎 Deploy Preview https://deploy-preview-18950--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (1651ed2) to head (93654f9).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18950      +/-   ##
==========================================
- Coverage   84.91%   84.88%   -0.03%     
==========================================
  Files         391      390       -1     
  Lines       14490    14467      -23     
  Branches     4742     4774      +32     
==========================================
- Hits        12304    12281      -23     
  Misses       2037     2037              
  Partials      149      149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@preetibansalui preetibansalui added this pull request to the merge queue Apr 15, 2025
Merged via the queue into carbon-design-system:main with commit bd0e13f Apr 15, 2025
37 checks passed
@adamalston adamalston deleted the 18948-event branch April 15, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite useEvent and useWindowEvent in TypeScript
4 participants