-
Notifications
You must be signed in to change notification settings - Fork 965
Brave rewards ui #3463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Brave rewards ui #3463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ee4130
to
0d76cdd
Compare
c149bc5
to
4565df1
Compare
f1ea250
to
e4fbd8a
Compare
e4fbd8a
to
0c94810
Compare
9 tasks
419276f
to
8205273
Compare
…are now context aware
…Rewards WelcomePage
This fixes history problem. More info here microsoft/TypeScript#28810. It was fixed here microsoft/TypeScript#29339 with version 3.4.x
8205273
to
cb6abd6
Compare
petemill
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this complex move! Very exciting, we can stop storing 6 git refs in our heads whenever we uplift 🍾
ryanml
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'+'.repeat(100)
7 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#6077
UI PR: brave/brave-ui#540
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Plan 1
Plan 2
Plan 3
npm run storybook
worksReviewer Checklist:
After-merge Checklist:
changes has landed on.