Skip to content

Brave rewards ui #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 342 commits into from
Sep 19, 2019
Merged

Brave rewards ui #3463

merged 342 commits into from
Sep 19, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 18, 2019

Resolves brave/brave-browser#6077

UI PR: brave/brave-ui#540

Submitter Checklist:

Test Plan:

Plan 1

  • make sure that CI is green

Plan 2

  • start browser
  • enable rewards
  • make sure that rewards page, panel and tip banner renders correctly

Plan 3

  • make sure that npm run storybook works

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Sep 18, 2019
@NejcZdovc NejcZdovc added this to the 0.72.x - Nightly milestone Sep 18, 2019
@NejcZdovc NejcZdovc force-pushed the fixes-resources branch 3 times, most recently from 7ee4130 to 0d76cdd Compare September 18, 2019 19:11
@NejcZdovc NejcZdovc changed the base branch from fixes-resources to master September 19, 2019 08:31
@NejcZdovc NejcZdovc force-pushed the brave-rewards-ui branch 2 times, most recently from f1ea250 to e4fbd8a Compare September 19, 2019 09:43
@NejcZdovc NejcZdovc requested review from petemill, cezaraugusto and a team September 19, 2019 09:46
@NejcZdovc NejcZdovc marked this pull request as ready for review September 19, 2019 09:46
@NejcZdovc NejcZdovc force-pushed the brave-rewards-ui branch 2 times, most recently from 419276f to 8205273 Compare September 19, 2019 18:36
NejcZdovc and others added 21 commits September 19, 2019 20:40
This fixes history problem. More info here microsoft/TypeScript#28810.

It was fixed here microsoft/TypeScript#29339 with version 3.4.x
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this complex move! Very exciting, we can stop storing 6 git refs in our heads whenever we uplift 🍾

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'+'.repeat(100)

@NejcZdovc NejcZdovc merged commit 4721259 into master Sep 19, 2019
@NejcZdovc NejcZdovc deleted the brave-rewards-ui branch September 19, 2019 21:04
NejcZdovc added a commit that referenced this pull request Oct 8, 2019
NejcZdovc added a commit that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move rewards related brave-ui into brave-core
9 participants