Skip to content

Manifest handler #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2018
Merged

Manifest handler #122

merged 2 commits into from
Jun 1, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 1, 2018

Submitter Checklist:

Fix brave/brave-browser#255

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@bbondy bbondy self-assigned this Jun 1, 2018
@bbondy bbondy requested a review from emerick June 1, 2018 17:12
emerick
emerick approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bbondy bbondy merged commit 7163957 into master Jun 1, 2018
@bsclifton bsclifton deleted the manifest-handler branch June 18, 2018 06:28
NejcZdovc pushed a commit that referenced this pull request Dec 10, 2018
@ryanml
Merge pull request #122 from brave-intl/rewards_panel_2
a37a77f 
Fixes naming found in PR review
NejcZdovc pushed a commit that referenced this pull request Sep 19, 2019
@ryanml @NejcZdovc
Rewards: Imported from brave-ui: Fixes #122, adds exclusion tooltip, …
fd189f6 
…fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @emerick