Skip to content

Commit cb6abd6

Browse files
committed
Fixes lint problems from brave-ui repository
1 parent fec5946 commit cb6abd6

File tree

17 files changed

+63
-49
lines changed

17 files changed

+63
-49
lines changed

components/brave_rewards/resources/ui/components/adRowsDetails/spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as React from 'react'
33
import { shallow } from 'enzyme'
44
import { create } from 'react-test-renderer'
55
import { TestThemeProvider } from 'brave-ui/theme'
6-
import AdRowsDetails from './index';
6+
import AdRowsDetails from './index'
77

88
describe('Ad Rows Details tests', () => {
99
const baseComponent = (props?: object) => <TestThemeProvider><AdRowsDetails id={'adRowsDetails'} /></TestThemeProvider>

components/brave_rewards/resources/ui/components/alert/spec.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@ import Alert, { Props } from './index'
66
import { TestThemeProvider } from 'brave-ui/theme'
77

88
describe('Alert tests', () => {
9-
const baseComponent = (props: Props) =>
9+
const baseComponent = (props: Props) => (
1010
<TestThemeProvider>
1111
<Alert id='alert' {...props} />
1212
</TestThemeProvider>
13+
)
1314

1415
describe('basic tests', () => {
1516
it('matches the snapshot', () => {

components/brave_rewards/resources/ui/components/amount/spec.tsx

+6-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@ import Amount from './index'
66
import { TestThemeProvider } from 'brave-ui/theme'
77

88
describe('Amount tests', () => {
9-
const baseComponent = (props?: object) => <TestThemeProvider><Amount id='amount' amount={1} converted={0.4} onSelect={() => {}} {...props} /></TestThemeProvider>
9+
const doNothing = () => { console.log('nothing') }
10+
const baseComponent = (props?: object) => (
11+
<TestThemeProvider>
12+
<Amount id='amount' amount={'1'} converted={'0.4'} onSelect={doNothing} {...props} />
13+
</TestThemeProvider>
14+
)
1015

1116
describe('basic tests', () => {
1217
it('matches the snapshot', () => {

components/brave_rewards/resources/ui/components/categoryLikePicker/spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as React from 'react'
33
import { shallow } from 'enzyme'
44
import { create } from 'react-test-renderer'
55
import { TestThemeProvider } from 'brave-ui/theme'
6-
import CategoryLikePicker from './index';
6+
import CategoryLikePicker from './index'
77

88
describe('Category Like Picker tests', () => {
99
const baseComponent = (props?: object) => <TestThemeProvider><CategoryLikePicker id={'categoryLikePicker'} optAction={0} /></TestThemeProvider>

components/brave_rewards/resources/ui/components/dropMenu/spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as React from 'react'
33
import { shallow } from 'enzyme'
44
import { create } from 'react-test-renderer'
55
import { TestThemeProvider } from 'brave-ui/theme'
6-
import DropMenu from './index';
6+
import DropMenu from './index'
77

88
describe('Drop Menu tests', () => {
99
const baseComponent = (props?: object) => <TestThemeProvider><DropMenu id={'dropMenu'} /></TestThemeProvider>

components/brave_rewards/resources/ui/components/mobile/boxMobile/index.tsx

+5-5
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ export default class BoxMobile extends React.PureComponent<Props, State> {
181181
<StyledLeft>
182182
{
183183
isDetailView
184-
? <StyledBackArrow onClick={this.setView.bind(this, 'index') as any}>
184+
? <StyledBackArrow onClick={this.setView.bind(this, 'index')}>
185185
<ArrowLeftIcon />
186186
</StyledBackArrow>
187187
: null
@@ -219,7 +219,7 @@ export default class BoxMobile extends React.PureComponent<Props, State> {
219219

220220
return (
221221
<StyledContent detailView={this.state.detailView}>
222-
<StyleDetailsLink onClick={this.setView.bind(this, 'detailView') as any}>
222+
<StyleDetailsLink onClick={this.setView.bind(this, 'detailView')}>
223223
{getLocale('viewDetails')}
224224
<StyledArrow>
225225
<CaratRightIcon />
@@ -232,7 +232,7 @@ export default class BoxMobile extends React.PureComponent<Props, State> {
232232
getSettingsListTitle = () => {
233233
return (
234234
<StyledMobileListWrapper>
235-
<StyledSettingsListTitle onClick={this.setView.bind(this, 'settings') as any}>
235+
<StyledSettingsListTitle onClick={this.setView.bind(this, 'settings')}>
236236
<StyledSettingsText>
237237
{getLocale('settings')}
238238
</StyledSettingsText>
@@ -253,14 +253,14 @@ export default class BoxMobile extends React.PureComponent<Props, State> {
253253

254254
return (
255255
<StyledFullSizeWrapper>
256-
<StyledSettingsClose onClick={this.setView.bind(this, 'detailView') as any}>
256+
<StyledSettingsClose onClick={this.setView.bind(this, 'detailView')}>
257257
<CloseStrokeIcon />
258258
</StyledSettingsClose>
259259
<StyledSettingsHeader>
260260
<StyledSettingsTitle>
261261
{this.getSettingsTitle(title)}
262262
</StyledSettingsTitle>
263-
<StyledSettingsClose onClick={this.setView.bind(this, 'detailView') as any}>
263+
<StyledSettingsClose onClick={this.setView.bind(this, 'detailView')}>
264264
<CloseStrokeIcon />
265265
</StyledSettingsClose>
266266
</StyledSettingsHeader>

components/brave_rewards/resources/ui/components/modalBackupRestore/spec.tsx

+9-8
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,20 @@ import ModalBackupRestore from './index'
66
import { TestThemeProvider } from 'brave-ui/theme'
77

88
describe('ModalBackupRestore tests', () => {
9+
const doNothing = () => { console.log('nothing') }
910
const baseComponent = (props?: object) => (
1011
<TestThemeProvider>
1112
<ModalBackupRestore
1213
id='modal'
13-
activeTabId={'backup'}
14+
activeTabId={0}
1415
recoveryKey={''}
15-
onClose={() => {}}
16-
onCopy={() => {}}
17-
onPrint={() => {}}
18-
onSaveFile={() => {}}
19-
onRestore={() => {}}
20-
onImport={() => {}}
21-
onTabChange={() => {}}
16+
onClose={doNothing}
17+
onCopy={doNothing}
18+
onPrint={doNothing}
19+
onSaveFile={doNothing}
20+
onRestore={doNothing}
21+
onImport={doNothing}
22+
onTabChange={doNothing}
2223
{...props}
2324
/>
2425
</TestThemeProvider>

components/brave_rewards/resources/ui/components/modalVerify/spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import * as React from 'react'
33
import { shallow } from 'enzyme'
44
import { create } from 'react-test-renderer'
5-
import PanelVerify from './index'
5+
import PanelVerify from './index'
66
import { TestThemeProvider } from 'brave-ui/theme'
77

88
describe('PanelVerify tests', () => {

components/brave_rewards/resources/ui/components/panelWelcome/spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import * as React from 'react'
33
import { shallow } from 'enzyme'
44
import { create } from 'react-test-renderer'
5-
import PanelWelcome from './index'
5+
import PanelWelcome from './index'
66
import { TestThemeProvider } from 'brave-ui/theme'
77

88
describe('PanelWelcome tests', () => {

components/brave_rewards/resources/ui/components/showAdsHistory/spec.tsx

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
/* This Source Code Form is subject to the terms of the Mozilla Public
22
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
3-
* You can obtain one at http://mozilla.org/MPL/2.0/.
4-
*/
3+
* You can obtain one at http://mozilla.org/MPL/2.0/. */
54

65
import * as React from 'react'
76
import { shallow } from 'enzyme'
87
import { create } from 'react-test-renderer'
9-
import ShowAdsHistory from './index';
8+
import ShowAdsHistory from './index'
109
import { TestThemeProvider } from 'brave-ui/theme'
1110

1211
describe('ShowAdsHistory tests', () => {

components/brave_rewards/resources/ui/components/tableAdsHistory/spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as React from 'react'
33
import { shallow } from 'enzyme'
44
import { create } from 'react-test-renderer'
55
import { TestThemeProvider } from 'brave-ui/theme'
6-
import TableAdsHistory from './index';
6+
import TableAdsHistory from './index'
77

88
describe('Amount tests', () => {
99
const baseComponent = (props?: object) => <TestThemeProvider><TableAdsHistory id={'tableAdsHistory'} header={[]} /></TestThemeProvider>

components/brave_rewards/resources/ui/components/thumbLikePicker/spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as React from 'react'
33
import { shallow } from 'enzyme'
44
import { create } from 'react-test-renderer'
55
import { TestThemeProvider } from 'brave-ui/theme'
6-
import ThumbLikePicker from './index';
6+
import ThumbLikePicker from './index'
77

88
describe('Amount tests', () => {
99
const baseComponent = (props?: object) => <TestThemeProvider><ThumbLikePicker id={'thumbLikePicker'} likeAction={0} /></TestThemeProvider>

components/brave_rewards/resources/ui/components/walletPopup/spec.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,17 @@ import { TestThemeProvider } from 'brave-ui/theme'
77

88
const props = {
99
onClose: () => null,
10-
userName: 'tester',
10+
userName: 'tester'
1111
}
1212

1313
describe('WalletSummary tests', () => {
14-
const baseComponent = (props: Props) =>
14+
const baseComponent = (props: Props) => (
1515
<TestThemeProvider>
1616
<WalletPopup id='wallet-popup' {...props} >
1717
<p>hi</p>
1818
</WalletPopup>
1919
</TestThemeProvider>
20+
)
2021

2122
describe('basic tests', () => {
2223
it('matches the snapshot', () => {

components/brave_rewards/resources/ui/components/walletSummary/spec.tsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,17 @@ const props = {
1212
contribute: { tokens: '10.0', converted: '0.25' },
1313
donation: { tokens: '2.0', converted: '0.25' },
1414
tips: { tokens: '19.0', converted: '5.25' },
15-
total: { tokens: '19.0', converted: '5.25' },
15+
total: { tokens: '19.0', converted: '5.25' }
1616
},
17-
onActivity: () => { }
17+
onActivity: () => { console.log('nothing') }
1818
}
1919

2020
describe('WalletSummary tests', () => {
21-
const baseComponent = (props: Props) =>
21+
const baseComponent = (props: Props) => (
2222
<TestThemeProvider>
2323
<WalletSummary id='empty' {...props} />
2424
</TestThemeProvider>
25+
)
2526

2627
describe('basic tests', () => {
2728
it('matches the snapshot', () => {

components/brave_rewards/resources/ui/components/welcomePage/spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import * as React from 'react'
33
import { shallow } from 'enzyme'
44
import { create } from 'react-test-renderer'
5-
import WelcomePage from './index'
5+
import WelcomePage from './index'
66
import { TestThemeProvider } from 'brave-ui/theme'
77

88
describe('WelcomePage tests', () => {

components/brave_rewards/resources/ui/stories/concepts.tsx

+16-11
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,20 @@ const dummyOptInAction = () => {
7272
storiesOf('Rewards/Concepts/Desktop', module)
7373
.addDecorator(withKnobs)
7474
.add('Settings Page', () => {
75+
const walletState: WalletState = select('wallet status', {
76+
unverified: 'unverified',
77+
verified: 'verified',
78+
'disconnected unverified': 'disconnected_unverified',
79+
'disconnected verified': 'disconnected_verified'
80+
}, 'unverified') as WalletState
81+
82+
type walletContent = 'empty' | 'summary' | 'off'
83+
const content: walletContent = select('Content', {
84+
empty: 'empty',
85+
summary: 'summary',
86+
off: 'off'
87+
}, 'empty') as any
88+
7589
const walletProps = {
7690
grants: object('Claimed grants', [
7791
{
@@ -90,17 +104,8 @@ storiesOf('Rewards/Concepts/Desktop', module)
90104
type: 'ads'
91105
}
92106
]),
93-
content: select('Content', {
94-
empty: 'empty',
95-
summary: 'summary',
96-
off: 'off'
97-
}, 'empty') as 'empty' | 'summary' | 'off',
98-
walletState: select('wallet status', {
99-
unverified: 'unverified',
100-
verified: 'verified',
101-
'disconnected unverified': 'disconnected_unverified',
102-
'disconnected verified': 'disconnected_verified'
103-
}, 'unverified') as WalletState
107+
content,
108+
walletState
104109
}
105110
return (<Settings {...{ walletProps }}/>)
106111
})

components/brave_rewards/resources/ui/stories/wallet.tsx

+8-7
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,13 @@ storiesOf('Rewards/Wallet/Desktop', module)
4040
const showAlert = boolean('Show alert', false)
4141
const showGrant = boolean('Show grants', false)
4242

43+
const state: WalletState = select('wallet status', {
44+
unverified: 'unverified',
45+
verified: 'verified',
46+
'disconnected unverified': 'disconnected_unverified',
47+
'disconnected verified': 'disconnected_verified'
48+
}, 'unverified') as WalletState
49+
4350
return (
4451
<WalletWrapper
4552
compact={false}
@@ -80,13 +87,7 @@ storiesOf('Rewards/Wallet/Desktop', module)
8087
}
8188
] : []}
8289
alert={showAlert ? alert : undefined}
83-
walletState={select('wallet status', {
84-
unverified: 'unverified',
85-
connected: 'connected',
86-
verified: 'verified',
87-
'disconnected unverified': 'disconnected_unverified',
88-
'disconnected verified': 'disconnected_verified'
89-
}, 'unverified') as WalletState}
90+
walletState={state}
9091
onDisconnectClick={doNothing}
9192
userName={'Brave Software'}
9293
>

0 commit comments

Comments
 (0)