Skip to content

Disable HTTPS first balanced mode #26277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 29, 2024

Resolves brave/brave-browser#41933

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick self-assigned this Oct 29, 2024
@emerick emerick requested a review from a team as a code owner October 29, 2024 13:00
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Oct 29, 2024
{kImmersiveFullscreen, base::FEATURE_DISABLED_BY_DEFAULT},
{kUseChromiumUpdater, base::FEATURE_DISABLED_BY_DEFAULT},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just keeping this one in alphabetical order.

Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emerick emerick merged commit 1473ecb into master Oct 29, 2024
18 checks passed
@emerick emerick deleted the cr131-followup-disable-https-first-balanced-mode branch October 29, 2024 20:07
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 29, 2024
emerick added a commit that referenced this pull request Oct 29, 2024
…st-balanced-mode

Disable HTTPS first balanced mode
@brave-builds
Copy link
Collaborator

Released in v1.73.57

emerick added a commit that referenced this pull request Oct 30, 2024
…st-balanced-mode

Disable HTTPS first balanced mode
emerick added a commit that referenced this pull request Oct 30, 2024
…st-balanced-mode

Disable HTTPS first balanced mode
emerick added a commit that referenced this pull request Oct 30, 2024
…st-balanced-mode

Disable HTTPS first balanced mode
kjozwiak pushed a commit that referenced this pull request Oct 31, 2024
* Upgrade from Chromium 130.0.6723.70 to Chromium 130.0.6723.91 (1.72.x) (#26296)

* Upgrade from Chromium 130.0.6723.70 to Chromium 130.0.6723.91

* Update pins list timestamp

---------

Co-authored-by: brave-builds <[email protected]>

* Merge pull request #25662 from brave/cr131

Upgrade from Chromium 130 to Chromium 131.

* Merge pull request #26256 from brave/cr131-followup-fix-extensions-sidebar-styles

Migrate extensions sidebar override to use Lit

* Merge pull request #26277 from brave/cr131-followup-disable-https-first-balanced-mode

Disable HTTPS first balanced mode

* Fixed SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProviderRestoreTest

fix brave/brave-browser#41470

TemplateURLService should be loaded before setting
prefs::kSyncedDefaultPrivateSearchProviderGUID prefs.

* [Android] Fix for crash in Password settings

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/df77cbacb9476b0b6d3e75cc34b5d127985e79c3

[Settings] Enable the single-activity mode by default

Bug: b/356743945

* [Android] Explicitly remove `New tab page cards` from menu

This item used in the upstream NTP, that we don't use.

---------

Co-authored-by: brave-builds <[email protected]>
Co-authored-by: Brian Clifton <[email protected]>
Co-authored-by: Simon Hong <[email protected]>
Co-authored-by: Artem Samoilenko <[email protected]>
@bsclifton bsclifton modified the milestones: 1.73.x - Nightly, 1.74.x - Nightly Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CR131 - Disable the flag for Allow enabling Balanced Mode for HTTPS-First Mode
4 participants