Skip to content

SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProviderRestoreTest failure #41470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonhong opened this issue Oct 8, 2024 · 0 comments · Fixed by brave/brave-core#25874
Closed

SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProviderRestoreTest failure #41470

simonhong opened this issue Oct 8, 2024 · 0 comments · Fixed by brave/brave-core#25874
Assignees
@simonhong
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.73.x - Release

Comments

@simonhong
Copy link
Member

Description

Reported by @bridiver

prefs::kSyncedDefaultPrivateSearchProviderGUID should be touched after template url service is loaded.

[ RUN      ] SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProviderRestoreTest
[57636:259:1006/122416.217132:WARNING:chrome_main_delegate.cc(744)] This is Chrome version 130.1.72.0 (not a warning)
[57642:259:1006/122416.353341:WARNING:viz_main_impl.cc(85)] VizNullHypothesis is disabled (not a warning)
[57636:259:1006/122416.365272:WARNING:external_provider_impl.cc(513)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
[57636:63747:1006/122416.370383:INFO:brave_referrals_service.cc(78)] Could not get promo code from /Users/jenkins/jenkins/workspace/re-build-pr-macos-arm64_PR-25828/src/out/Static_arm64. The extended attribute com.brave.refcode was not found.
[57636:259:1006/122416.783748:ERROR:client_tag_based_data_type_processor.cc(162)] The persisted metadata was invalid and was cleared for Device Info. Start over fresh.
[57636:259:1006/122416.787811:FATAL:search_engine_provider_util.cc(98)] Check failed: service->loaded(). 
0   brave_browser_tests                 0x00000001083992dc base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) + 28
1   brave_browser_tests                 0x0000000108388798 base::debug::StackTrace::StackTrace(unsigned long) + 108
2   brave_browser_tests                 0x00000001082acab8 logging::LogMessage::Flush() + 152
3   brave_browser_tests                 0x00000001082ac9ac logging::LogMessage::~LogMessage() + 36
4   brave_browser_tests                 0x0000000108293350 logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() + 124
5   brave_browser_tests                 0x00000001082933a0 logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() + 12
6   brave_browser_tests                 0x0000000108292e98 logging::CheckError::~CheckError() + 44
7   brave_browser_tests                 0x0000000108292ee0 logging::CheckError::~CheckError() + 12
8   brave_browser_tests                 0x00000001070d0240 brave::UpdateDefaultPrivateSearchProviderData(Profile*) + 320
9   brave_browser_tests                 0x00000001002a0630 base::RepeatingCallback<void ()>::Run() const & + 80
10  brave_browser_tests                 0x000000010056598c base::RepeatingCallback<void (absl::variant<base::StrongAlias<password_manager::(anonymous namespace)::AffiliatedRealmsTag,
@simonhong simonhong self-assigned this Oct 8, 2024
@simonhong simonhong mentioned this issue Oct 8, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 10, 2024
emerick pushed a commit to brave/brave-core that referenced this issue Oct 30, 2024
@simonhong @emerick
Fixed SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProvide…
593c7da 
…rRestoreTest

fix brave/brave-browser#41470

TemplateURLService should be loaded before setting
prefs::kSyncedDefaultPrivateSearchProviderGUID prefs.
@emerick emerick mentioned this issue Oct 30, 2024
Merged
24 tasks
kjozwiak pushed a commit to brave/brave-core that referenced this issue Oct 31, 2024
@emerick @brave-builds
@bsclifton @simonhong @samartnik
Upgrade from Chromium 130 to Chromium 131 1.72.x (#26222)
2af1342 
* Upgrade from Chromium 130.0.6723.70 to Chromium 130.0.6723.91 (1.72.x) (#26296)

* Upgrade from Chromium 130.0.6723.70 to Chromium 130.0.6723.91

* Update pins list timestamp

---------

Co-authored-by: brave-builds <[email protected]>

* Merge pull request #25662 from brave/cr131

Upgrade from Chromium 130 to Chromium 131.

* Merge pull request #26256 from brave/cr131-followup-fix-extensions-sidebar-styles

Migrate extensions sidebar override to use Lit

* Merge pull request #26277 from brave/cr131-followup-disable-https-first-balanced-mode

Disable HTTPS first balanced mode

* Fixed SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProviderRestoreTest

fix brave/brave-browser#41470

TemplateURLService should be loaded before setting
prefs::kSyncedDefaultPrivateSearchProviderGUID prefs.

* [Android] Fix for crash in Password settings

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/df77cbacb9476b0b6d3e75cc34b5d127985e79c3

[Settings] Enable the single-activity mode by default

Bug: b/356743945

* [Android] Explicitly remove `New tab page cards` from menu

This item used in the upstream NTP, that we don't use.

---------

Co-authored-by: brave-builds <[email protected]>
Co-authored-by: Brian Clifton <[email protected]>
Co-authored-by: Simon Hong <[email protected]>
Co-authored-by: Artem Samoilenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProvide… brave/brave-core
2 participants
@simonhong @brave-builds