Skip to content

CR131 - Disable the flag for Allow enabling Balanced Mode for HTTPS-First Mode #41933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
MadhaviSeelam opened this issue Oct 28, 2024 · 2 comments · Fixed by brave/brave-core#26277
Closed
1 of 6 tasks

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 28, 2024

Description

Found while testing #41882. #https-first-balanced-mode flag is enabled in brave://flags via upstream. Disable the flag to hide Always use secure connections entry is shown in brave://settings/security.

Steps to reproduce

  1. Install 1.73.52
  2. launch Brave
  3. open brave://flags/#https-first-balanced-mode
  4. open brave://settings/security

Actual result

Allow enabling Balanced Mode for HTTPS-First Mode flag is shown as enabled
Always use secure connections entry shown as disabled in brave://settings/security

example example
Image Image

Expected result

Disable Allow enabling Balanced Mode for HTTPS-First Mode flag

example example
Image Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.73.52 Chromium: 131.0.6778.14 (Official Build) nightly (64-bit)
-- | --
Revision | 6996738c6195caf95549bd8a9bb48be180b4b62f
OS | Windows 11 Version 23H2 (Build 22631.4391)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

@emerick

cc: @rebron @brave/qa-team

@GeetaSarvadnya GeetaSarvadnya changed the title Disable the flag for Allow enabling Balanced Mode for HTTPS-First Mode CR131 - Disable the flag for Allow enabling Balanced Mode for HTTPS-First Mode Oct 29, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 29, 2024
@emerick emerick self-assigned this Oct 30, 2024
@kjozwiak
Copy link
Member

The above requires 1.72.92 or higher for 1.72.x verification 👍

@MadhaviSeelam
Copy link
Author

Verification PASSED using

Brave | 1.72.93 Chromium: 131.0.6778.14 (Official Build) beta (64-bit)
-- | --
Revision | 69e5dc20ca483a13316632df5bcd9279bb2a3cb7
OS | Windows 11 Version 23H2 (Build 22631.4391)

Confirmed #https-first-balanced-mode is shown as disabled by default.

Confirmed brave://settings/security page do not show Always use secure connections setting

brave://flags/#https-first-balanced-mode brave://settings/security
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants