Skip to content

[iOS] Update "Deprecated Sync Code Message" and "Delete Sync Account #23399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2024

Conversation

soner-yuksel
Copy link
Contributor

Resolves brave/brave-browser#37775
Resolves brave/brave-browser#37633

Changing Sync Code and Deletion Messages to latest version

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan & Screenshot:

-Test Delete Sync Code Message and Updated "Deprecated Sync Code Message"

@soner-yuksel soner-yuksel added CI/run-linux-arm64 Run CI builds for Linux arm64 CI/run-windows-arm64 Run CI builds for Windows arm64 unused-CI/run-macos-arm64 Run CI builds for macOS arm64 labels May 2, 2024
@soner-yuksel soner-yuksel self-assigned this May 2, 2024
@soner-yuksel soner-yuksel marked this pull request as ready for review May 3, 2024 14:22
@soner-yuksel soner-yuksel requested a review from a team as a code owner May 3, 2024 14:22
@soner-yuksel soner-yuksel requested a review from kylehickinson May 3, 2024 16:07
@soner-yuksel soner-yuksel merged commit 746c975 into master May 3, 2024
19 checks passed
@soner-yuksel soner-yuksel deleted the ios/bugfix/sync-format-updates branch May 3, 2024 17:45
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-linux-arm64 Run CI builds for Linux arm64 CI/run-windows-arm64 Run CI builds for Windows arm64 unused-CI/run-macos-arm64 Run CI builds for macOS arm64
Projects
None yet
2 participants