Skip to content

[iOS] Update "Deprecated Sync Code Message" and "Delete Sync Account #23399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2024
Merged

[iOS] Update "Deprecated Sync Code Message" and "Delete Sync Account #23399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5d90d7
Changing Sync Code Deletion Messages to latest version
soner-yuksel May 2, 2024
aae99bd
Fixing duplicated keys syncDeleteAccountAlertDescriptionPart2
soner-yuksel May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/brave-ios/Sources/Brave/Frontend/Sync/SyncSettingsTableViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ class SyncSettingsTableViewController: SyncViewController, UITableViewDelegate,
case .syncChainDeleteConfirmation:
title = Strings.Sync.syncDeleteAccountAlertTitle
message =
"\(Strings.Sync.syncDeleteAccountAlertDescriptionPart1).\n\n\(Strings.Sync.syncDeleteAccountAlertDescriptionPart2)"
"\(Strings.Sync.syncDeleteAccountAlertDescriptionPart1)\n\n\(Strings.Sync.syncDeleteAccountAlertDescriptionPart2)\n\n\(Strings.Sync.syncDeleteAccountAlertDescriptionPart3)"
removeButtonName = Strings.delete
case .syncChainDeleteError:
title = Strings.Sync.syncChainAccountDeletionErrorTitle
Expand Down
14 changes: 11 additions & 3 deletions ios/brave-ios/Sources/BraveStrings/BraveStrings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2829,7 +2829,7 @@ extension Strings {
tableName: "BraveShared",
bundle: .module,
value:
"This sync code was generated by an outdated version of Brave on another device. Please update Brave on all synced devices and try again.",
"It looks like this code was created on a device running an older version of Brave. Please update to the latest version of Brave on your other device, and then create a new sync code.",
comment: "Sync Error Description"
)
public static let syncExpiredError = NSLocalizedString(
Expand Down Expand Up @@ -8348,17 +8348,25 @@ extension Strings {
tableName: "BraveShared",
bundle: .module,
value:
"Deleting your account will remove your encrypted data from Brave servers and disable Sync on all of your connected devices. It will not however delete the data that is stored locally on those devices.",
"Deleting your account will remove your encrypted data from Brave servers and disable Sync on all of your connected devices.",
comment: "Part 1 Description for Alert used action Delete Sync Account."
)
public static let syncDeleteAccountAlertDescriptionPart2 =
NSLocalizedString(
"sync.syncDeleteAccountAlertDescriptionPart2",
tableName: "BraveShared",
bundle: .module,
value: "It will not however delete the data that is stored locally on those devices.",
comment: "Part 2 Description for Alert used action Delete Sync Account."
)
public static let syncDeleteAccountAlertDescriptionPart3 =
NSLocalizedString(
"sync.syncDeleteAccountAlertDescriptionPart3",
tableName: "BraveShared",
bundle: .module,
value:
"This deletion is permanent and there is no way to recover the data. Should you decide to start using Sync again, you will need to create a new account and re-add each device one by one.",
comment: "Part 2 Description for Alert used action Delete Sync Account."
comment: "Part 3 Description for Alert used action Delete Sync Account."
)
public static let syncChainAlreadyDeletedAlertTitle =
NSLocalizedString(
Expand Down
Loading