Skip to content

feat(wallet): Wallet iOS Deposit (Uplift to 1.64.x) #22924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2024
Merged

feat(wallet): Wallet iOS Deposit (Uplift to 1.64.x) #22924

merged 2 commits into from
Apr 5, 2024

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Apr 3, 2024 •
edited by kjozwiak
Loading

Uplift of #22453
Uplift of #22816
Resolves brave/brave-browser#35988
Resolves brave/brave-browser#37123

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@nuo-xu nuo-xu added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Apr 3, 2024
@nuo-xu nuo-xu self-assigned this Apr 3, 2024
@nuo-xu nuo-xu requested a review from a team as a code owner April 3, 2024 21:18
@kjozwiak kjozwiak added this to the 1.64.x - Release #4 milestone Apr 5, 2024
kjozwiak
kjozwiak approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.64.x approved 👍 QA has verified the PR on Nightly using 1.66.x as per #22816 (comment) & #22453 (comment).

@kjozwiak kjozwiak merged commit 4c86fdc into 1.64.x Apr 5, 2024
@kjozwiak kjozwiak deleted the uplift/1.64.x-wallet-ios-deposit branch April 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@nuo-xu nuo-xu

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.64.x - Release #4
Development

Successfully merging this pull request may close these issues.
2 participants
@nuo-xu @kjozwiak