Skip to content

Deposit can shown incorrect accounts for token #37123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StephenHeaps opened this issue Mar 27, 2024 · 3 comments · Fixed by brave/brave-core#22816
Closed

Deposit can shown incorrect accounts for token #37123

StephenHeaps opened this issue Mar 27, 2024 · 3 comments · Fixed by brave/brave-core#22816
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude

Comments

@StephenHeaps
Copy link

Description:

In Deposit, selecting FIL on Filecoin Mainnet will show all Filecoin accounts, including Filecoin Testnet accounts.
In Deposit, selecting FIL on Filecoin Testnet will show all Filecoin accounts, including Filecoin Mainnet accounts.

In Asset Detail for FIL on Filecoin Mainnet will show all Filecoin accounts, including Filecoin Testnet accounts.
In Asset Detail for FIL on Filecoin Testnet will show all Filecoin accounts, including Filecoin Mainnet accounts.

Steps to Reproduce

Deposit:

  1. Have at least 1 Filecoin account on Filecoin Mainnet and 1 Filecoin account on Filecoin Testnet
  2. Open Deposit
  3. Search/Filter for FIL
  4. Open FIL on Filecoin Mainnet
  5. Observe test network accounts shown
  6. Tap back, open FIL on Filecoin Testnet
  7. Observe mainnet accounts shown

Asset Detail View (only a Filecoin Mainnet account exists):

  1. Have 1 Filecoin Mainnet account and open FIL on Filecoin Testnet in Asset Detail
  2. Tap Deposit, observe Filecoin Mainnet account is shown as selected

Asset Detail View (only a Filecoin Testnet account exists):

  1. Have 1 Filecoin Testnet account and open FIL on Filecoin Mainnet in Asset Detail
  2. Tap Deposit, observe Filecoin Testnet account is shown as selected

Actual result:

Expected result:

Only Filecoin Mainnet accounts are shown in deposit for FIL on Filecoin Mainnet
Only Filecoin Testnet accounts are shown in deposit for FIL on Filecoin Testnet

Reproduces how often:

Easily reproduced

Brave Version:

v1.66+

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2024

The above requires 1.64.118 or higher for 1.64.x verification 👍 @srirambv @nuo-xu added release-notes/include but let me know if it should be release-notes/exclude. We're uplifting into Release so assuming it's affecting users.

@srirambv
Copy link
Contributor

srirambv commented Apr 8, 2024

This should be exclude. It regressed in 1.64.x but works fine in 1.63.x

@srirambv
Copy link
Contributor

srirambv commented Apr 8, 2024

Verification passed on iPhone 13 with iOS 17.4.1 running 1.64 (119)

  • Verified steps from brave/brave-core#22816
  • Verified when no FIL account is created, selecting Deposit and selecting FIL mainnet/testnet prompts to create the account
  • Verified with FIL Mainnet account created, selecting Deposit and selecting FIL Testnet prompts to create the Testnet account
  • Verified with FIL Testnet account created, selecting Deposit and selecting FIL Mainnet prompts to create the Mainnet account
  • Verified with FIL Mainnet and FIL Testnet account selecting Deposit and selecting Mainnet loads Mainnet accounts only and selecting Testnet account loads Testnet accounts only
Case 1 Case 2 Case 3 Case 4
37123.-Case1.MP4
37123.-Case2.MP4
37123.-Case3.MP4
37123.-Case4.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
None yet
5 participants