Skip to content

Wallet: Asset Deposit #35988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nuo-xu opened this issue Jan 11, 2024 · 2 comments · Fixed by brave/brave-core#22453
Closed

Wallet: Asset Deposit #35988

nuo-xu opened this issue Jan 11, 2024 · 2 comments · Fixed by brave/brave-core#22453
Assignees
@nuo-xu
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.64.x - Release #4

Comments

@nuo-xu
Copy link

nuo-xu commented Jan 11, 2024 •
edited by StephenHeaps
Loading

Description:

Should be a reusable modal view. Linked to ... button in each account card in Accounts tab v2, Account Details v2, etc.

Accounts Deposit

Locations:
Portfolio
Asset Detail
Assets in Market tab
Account Details
@nuo-xu nuo-xu added the QA/Yes label Jan 11, 2024
@nuo-xu nuo-xu transferred this issue from brave/brave-ios Feb 12, 2024
@nuo-xu nuo-xu added feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality labels Feb 12, 2024
@nuo-xu nuo-xu mentioned this issue Mar 4, 2024
Merged
24 tasks
@StephenHeaps StephenHeaps mentioned this issue Mar 7, 2024
Closed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Mar 18, 2024
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Mar 18, 2024
This was referenced Apr 3, 2024
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2024

The above requires 1.64.118 or higher for 1.64.x verification 👍

@kjozwiak kjozwiak mentioned this issue Apr 5, 2024
Closed
25 tasks
@srirambv
Copy link
Contributor

srirambv commented Apr 8, 2024

Verification passed on iPhone 13 with iOS 17.4.1 running 1.64 (119)

  • Verified steps from brave/brave-core#22453
  • Verified Deposit works as expected
  • Verified Deposit option works from Portfolio, Account details menu, Asset details screen and Market token details screen
  • Verified Deposit auto fills token details when opened from Asset details screen
  • Verified Deposit screen for Eth tokens shows disclaimer message
  • Verified searching for a token on multichain the disclaimer message is only shown for ETH/EVM network tokens
  • Verified when there is no account created, selecting deposit brings up the account creation message. Additional notes here
35988.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuo-xu nuo-xu

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.64.x - Release #4
Development

Successfully merging a pull request may close this issue.

[Wallet/iOS] Fix #35988: Deposit Support on Wallet iOS brave/brave-core
4 participants
@nuo-xu @kjozwiak @srirambv @brave-builds