Skip to content

[iOS] - Uplift Leo QA Iteration 4 - 1.64.x #22812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2024
Merged

[iOS] - Uplift Leo QA Iteration 4 - 1.64.x #22812

merged 3 commits into from
Mar 28, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Mar 27, 2024 •
edited by kjozwiak
Loading

Uplift of #22791
Uplift of #22608
Resolves brave/brave-browser#37138
Resolves brave/brave-browser#37136
Resolves brave/brave-browser#36805
Resolves brave/brave-browser#37150

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Mar 27, 2024
@Brandon-T Brandon-T added this to the 1.64.x - Release #2 milestone Mar 27, 2024
@Brandon-T Brandon-T self-assigned this Mar 27, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner March 27, 2024 15:30
@Brandon-T Brandon-T force-pushed the bugfix/Leo-iOS-QAIteration-4-1.64.x branch 2 times, most recently from c9873be to cba7b3b Compare March 27, 2024 16:38
@Brandon-T
[iOS] - Retry Leo Purchases & Add Logging (#22791)
3b3bea7 
* Add Logging View for Leo Purchases.
* Add logs everywhere which can be accessed via Console.app
* Retry purchase receipt syncing up to 10 times if purchase transaction was verified.
* Revert manual refreshing logic as it doesn't help.
* Fix performance of rendering chat messages.

Signed-off-by: Brandon T <[email protected]>
@Brandon-T
[iOS] - Fix layout of WrappingHStack when text becomes multi-line (#2…
8099328 
…2608)

* Fix layout of WrappingHStack when text becomes multi-line.
* Also fix spacing between items in the wrapping HStack on iOS 15 when line becomes multi-line.

Signed-off-by: Brandon T <[email protected]>
@Brandon-T
Fix compilation.Throw error when payment processing fails.
74a16cf 
Signed-off-by: Brandon T <[email protected]>
@Brandon-T Brandon-T force-pushed the bugfix/Leo-iOS-QAIteration-4-1.64.x branch from cba7b3b to 74a16cf Compare March 28, 2024 01:08
kjozwiak
kjozwiak approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.64.x approved 👍

@kjozwiak kjozwiak merged commit 28e9291 into 1.64.x Mar 28, 2024
@kjozwiak kjozwiak deleted the bugfix/Leo-iOS-QAIteration-4-1.64.x branch March 28, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.64.x - Release #3
Development

Successfully merging this pull request may close these issues.
2 participants
@Brandon-T @kjozwiak