Skip to content

[iOS] - Wrapping HStack Spacing inconsistent #36805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Brandon-T opened this issue Mar 14, 2024 · 3 comments · Fixed by brave/brave-core#22608
Closed

[iOS] - Wrapping HStack Spacing inconsistent #36805

Brandon-T opened this issue Mar 14, 2024 · 3 comments · Fixed by brave/brave-core#22608

Comments

@Brandon-T
Copy link

Brandon-T commented Mar 14, 2024

Description:

  • Sometimes when the Wrapping HStack overflows, the spacing between elements can be different from all other spacing in the stack. Spacing should be always the same
  • On iOS 15, the "Suggested Questions" are sometimes mis-aligned. Especially if the suggested-question is multi-line, sometimes it leaves a GAP in between questions that are too large.

Steps to Reproduce

  1. Add a button where the title is very long so that it overflows onto the second or third line
  2. Add more buttons that are single line or more

Actual result:

  • Incorrect spacing between buttons

Expected result:

  • Spacing should always be consistent

Reproduces how often: [Easily reproduced, Intermittent Issue]

  • Intermittent Issue

Brave Version:

  • 1.63.x
@kjozwiak
Copy link
Member

The above requires 1.63.183 or higher for 1.63.x verification 👍

@Uni-verse
Copy link
Contributor

Verified on iPad (9th Gen) running iOS 15.6.1 using version 1.63.2 (183)

  • Ensured spacing looks consistent for Suggested questions and Summarize buttons
Example Example Example
IMG_0370 2 IMG_0371 2 IMG_0372 2

@hffvld
Copy link
Contributor

hffvld commented Mar 28, 2024

Verified on iPhone 14using version(s):

Device/OS: iPhone 14 / iOS 17.4.1
Brave build: 1.63.2 (183)
BraveCore: 1.63.183 (122.0.6261.128)

STEPS:

  1. Launch Brave
  2. Go to any website
  3. Open Leo
  4. Tap Suggest questions... > Verify

ACTUAL RESULTS:

  • Verified that vertical spacing between buttons has the same size

1 2
1 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants