Skip to content

[iOS] - Fix layout of WrappingHStack when text becomes multi-line #22608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

[iOS] - Fix layout of WrappingHStack when text becomes multi-line #22608

merged 1 commit into from
Mar 27, 2024

Conversation

Brandon-T
Copy link
Contributor

Also fix spacing between items in the wrapping HStack on iOS 15 when line becomes multi-line.

Resolves brave/brave-browser#36805

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T
Fix layout of WrappingHStack when text becomes multi-line.
50350f2 
Also fix spacing between items in the wrapping HStack on iOS 15 when line becomes multi-line.
@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Mar 14, 2024
@Brandon-T Brandon-T added this to the 1.65.x - Beta milestone Mar 14, 2024
@Brandon-T Brandon-T self-assigned this Mar 14, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner March 14, 2024 19:56
kylehickinson
kylehickinson reviewed Mar 14, 2024
View reviewed changes
ios/brave-ios/Sources/AIChat/Components/Messages/AIChatSuggestionsView.swift
}

subview.place(
at: CGPoint(x: x, y: y),
anchor: .center,
anchor: .init(x: 0.5, y: 1.0),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same as bottom?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes correct it is.
I was just being a bit more explicit. But honestly I'll just change it back to .bottom.
It was just easier for me to see that it's 0.5 horizontally (centred), and 1.0 (bottom) :)

@kylehickinson kylehickinson removed this from the 1.65.x - Beta milestone Mar 18, 2024
@Brandon-T Brandon-T added this to the 1.66.x - Nightly milestone Mar 27, 2024
@Brandon-T Brandon-T requested a review from kylehickinson March 27, 2024 01:26
@Brandon-T Brandon-T merged commit 51473fd into master Mar 27, 2024
@Brandon-T Brandon-T deleted the bugfix/Leo-Suggestions branch March 27, 2024 15:12
This was referenced Mar 27, 2024
Merged
Merged
@Brandon-T Brandon-T mentioned this pull request Mar 27, 2024
Merged
24 tasks
Brandon-T added a commit that referenced this pull request Mar 28, 2024
@Brandon-T
[iOS] - Fix layout of WrappingHStack when text becomes multi-line (#2…
aaf51f1 
…2608)

* Fix layout of WrappingHStack when text becomes multi-line.
* Also fix spacing between items in the wrapping HStack on iOS 15 when line becomes multi-line.

Signed-off-by: Brandon T <[email protected]>
Brandon-T added a commit that referenced this pull request Mar 28, 2024
@Brandon-T
[iOS] - Fix layout of WrappingHStack when text becomes multi-line (#2…
8099328 
…2608)

* Fix layout of WrappingHStack when text becomes multi-line.
* Also fix spacing between items in the wrapping HStack on iOS 15 when line becomes multi-line.

Signed-off-by: Brandon T <[email protected]>
Brandon-T added a commit that referenced this pull request Mar 28, 2024
@Brandon-T
[iOS] - Fix layout of WrappingHStack when text becomes multi-line (#2…
1f09405 
…2608)

* Fix layout of WrappingHStack when text becomes multi-line.
* Also fix spacing between items in the wrapping HStack on iOS 15 when line becomes multi-line.

Signed-off-by: Brandon <[email protected]>
Signed-off-by: Brandon T <[email protected]>
kjozwiak pushed a commit that referenced this pull request Mar 28, 2024
@Brandon-T
[iOS] - Uplift Leo QA Iteration 4 - 1.65.x (#22811)
ac5ecf2 
* [iOS] - Retry Leo Purchases & Add Logging (#22791)

* Add Logging View for Leo Purchases.
* Add logs everywhere which can be accessed via Console.app
* Retry purchase receipt syncing up to 10 times if purchase transaction was verified.
* Revert manual refreshing logic as it doesn't help.
* Fix performance of rendering chat messages.

Signed-off-by: Brandon <[email protected]>
Signed-off-by: Brandon T <[email protected]>

* [iOS] - Fix layout of WrappingHStack when text becomes multi-line (#22608)

* Fix layout of WrappingHStack when text becomes multi-line.
* Also fix spacing between items in the wrapping HStack on iOS 15 when line becomes multi-line.

Signed-off-by: Brandon <[email protected]>
Signed-off-by: Brandon T <[email protected]>

* Throw error when payment processing fails.

Signed-off-by: Brandon T <[email protected]>

---------

Signed-off-by: Brandon <[email protected]>
Signed-off-by: Brandon T <[email protected]>
kjozwiak pushed a commit that referenced this pull request Mar 28, 2024
@Brandon-T
[iOS] - Uplift Leo QA Iteration 4 - 1.64.x (#22812)
28e9291 
* [iOS] - Retry Leo Purchases & Add Logging (#22791)

* Add Logging View for Leo Purchases.
* Add logs everywhere which can be accessed via Console.app
* Retry purchase receipt syncing up to 10 times if purchase transaction was verified.
* Revert manual refreshing logic as it doesn't help.
* Fix performance of rendering chat messages.

Signed-off-by: Brandon T <[email protected]>

* [iOS] - Fix layout of WrappingHStack when text becomes multi-line (#22608)

* Fix layout of WrappingHStack when text becomes multi-line.
* Also fix spacing between items in the wrapping HStack on iOS 15 when line becomes multi-line.

Signed-off-by: Brandon T <[email protected]>

* Fix compilation.Throw error when payment processing fails.

Signed-off-by: Brandon T <[email protected]>

---------

Signed-off-by: Brandon T <[email protected]>
kjozwiak pushed a commit that referenced this pull request Mar 28, 2024
@Brandon-T
[iOS] - Uplift Leo QA Iteration 4 - 1.63.x (#22815)
6f0b967 
* [iOS] - Retry Leo Purchases & Add Logging (#22791)

* Add Logging View for Leo Purchases.
* Add logs everywhere which can be accessed via Console.app
* Retry purchase receipt syncing up to 10 times if purchase transaction was verified.
* Revert manual refreshing logic as it doesn't help.
* Fix performance of rendering chat messages.

Signed-off-by: Brandon T <[email protected]>

* [iOS] - Fix layout of WrappingHStack when text becomes multi-line (#22608)

* Fix layout of WrappingHStack when text becomes multi-line.
* Also fix spacing between items in the wrapping HStack on iOS 15 when line becomes multi-line.

Signed-off-by: Brandon T <[email protected]>

* Fix compilation.Throw error when payment processing fails.

Signed-off-by: Brandon T <[email protected]>

---------

Signed-off-by: Brandon T <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging this pull request may close these issues.

[iOS] - Wrapping HStack Spacing inconsistent
2 participants
@Brandon-T @kylehickinson