-
Notifications
You must be signed in to change notification settings - Fork 964
Add proguard rule for datatransport runtime [Uplift to 1.58.x] #20163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,3 +1,5 @@ | |||
-keep class com.google.android.datatransport.runtime.scheduling.** { *; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We needed to add proguard rule because of https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/third_party/android_deps/buildSrc/src/main/groovy/ChromiumDepGraph.groovy;l=39. and for some reason it seems to be affecting only android 8.
Both @vlad-hoff & @Uni-verse confirmed that the crash appears to be resolved once they ran through a quick spot check with builds that @deeppandya provided which had the above fix. Because the timestamp_18-15-31_18-18-10.mp4 |
Followed the STR from the issue. and it seems to be working as expected. it doesn't crash at all and i was also able to buy the subscription and start the vpn tunnel. Here i have attached the recording with 1.58.123 manual build . az_recorder_20230914_030029.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 1.58.x
approved 👍 QA & @deeppandya went through verifications on a PR build as per #20163 (comment) & #20163 (comment).
Uplift of #20165
Resolves brave/brave-browser#32988
Pre-approval checklist:
Pre-merge checklist:
Post-merge checklist: