Skip to content

Add proguard rule for datatransport runtime #20165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#32988

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Sep 14, 2023
@deeppandya deeppandya added this to the 1.60.x - Nightly milestone Sep 14, 2023
@deeppandya deeppandya self-assigned this Sep 14, 2023
@deeppandya
Copy link
Contributor Author

We needed to add proguard rule because of https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/third_party/android_deps/buildSrc/src/main/groovy/ChromiumDepGraph.groovy;l=39. and for some reason it seems to be affecting only android 8.

@deeppandya
Copy link
Contributor Author

deeppandya commented Sep 14, 2023

i was unable to reproduce on latest master changes. but i was able to reproduce the issue on sony xperia device with android 8.

Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

QA & @deeppandya went through verifications on a PR build as per #20163 (comment) & #20163 (comment).

@deeppandya deeppandya merged commit 8f0e5e8 into master Sep 14, 2023
@deeppandya deeppandya deleted the resolve_android_8_vpn_issue_master branch September 14, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes shortly after launch on fresh profile [Android 8.1.0]
3 participants