Skip to content

Add proguard rule for datatransport runtime [Uplift to 1.58.x] #20163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions android/java/proguard.flags
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
-keep class com.google.android.datatransport.runtime.scheduling.** { *; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed to add proguard rule because of https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/third_party/android_deps/buildSrc/src/main/groovy/ChromiumDepGraph.groovy;l=39. and for some reason it seems to be affecting only android 8.


-keep class com.google.android.material.bottomsheet.BottomSheetBehavior { *; }

-keep class org.chromium.chrome.browser.BraveSyncWorker { *; }
Expand Down