Fix missing Ethereum permissions header #17390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
emerick
deleted the
cr111-followup-fix-missing-ethereum-permissions-header
branch
emerick
added a commit
that referenced
this pull request
Feb 27, 2023
…eum-permissions-header Fix missing Ethereum permissions header
kjozwiak
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Merge pull request #17033 from brave/cr111 * Partial refactor of PageGraph to use WTF types (#16953) This is a partial refactor of PageGraph to make use of WTF types where possible. A much larger change enforcing the use of WTF::String will be submitted separately. The changes in this PR are aiming in making that work easier. Chromium change: https://chromium.googlesource.com/chromium/src/+/52472aba170b71f97ae9ab17f429ff494537adae commit 52472aba170b71f97ae9ab17f429ff494537adae Author: Xianzhu Wang <[email protected]> Date: Mon Jan 9 20:26:58 2023 +0000 Enable discouraged type check for data members under blink/renderer For existing usages of discouraged type: - Simple cases are changed to use blink types; - For other cases, ALLOW_DISCOURAGED_TYPE(reason) is added. Rules audit_non_blink_usages.py checking such usages are removed. We'll use the clang plugin from now on. Bug: 1363780 * Using WTF::String for blink data members (#16988) Upstream chromium has rolled out clang checks in upcoming versions that will error out in cases where blink headers are using `std::string` as data member type. This change replaces all uses of `std::string` with `WTF::String` for data members in blink headers. Chromium change: https://chromium.googlesource.com/chromium/src/+/52472aba170b71f97ae9ab17f429ff494537adae commit 52472aba170b71f97ae9ab17f429ff494537adae Author: Xianzhu Wang <[email protected]> Date: Mon Jan 9 20:26:58 2023 +0000 Enable discouraged type check for data members under blink/renderer For existing usages of discouraged type: - Simple cases are changed to use blink types; - For other cases, ALLOW_DISCOURAGED_TYPE(reason) is added. Rules audit_non_blink_usages.py checking such usages are removed. We'll use the clang plugin from now on. Bug: 1363780 Change-Id: I808524abc06c24d8f0f9867c06f4c6597bff1889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4130490 Commit-Queue: Xianzhu Wang <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1090474} * Merge pull request #17389 from brave/cr111-followup-fix-missing-shield-settings-header Fix missing Shield settings header * Merge pull request #17390 from brave/cr111-followup-fix-missing-ethereum-permissions-header Fix missing Ethereum permissions header * Upgrade from Chromium 111.0.5563.33 to Chromium 111.0.5563.41 (#17349) * Upgrade from Chromium 111.0.5563.33 to Chromium 111.0.5563.41 * Upgrade patches from Chromium 111.0.5563.33 to Chromium 111.0.5563.41 * Update pins list timestamp * Disable new DIPS-related upstream unit test --------- Co-authored-by: brave-builds <[email protected]> * [Android] Fix for rotation of NTP images * Resolve rewards ANR with external wallet provider --------- Co-authored-by: cdesouza-chromium <[email protected]> Co-authored-by: brave-builds <[email protected]> Co-authored-by: Artem Samoilenko <[email protected]> Co-authored-by: deeppandya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#28773
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: