Skip to content

Commit 2691591

Browse files
authored
Merge pull request #17390 from brave/cr111-followup-fix-missing-ethereum-permissions-header
Fix missing Ethereum permissions header
2 parents da7e823 + 950441b commit 2691591

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

browser/resources/settings/brave_overrides/site_details.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,14 @@ RegisterPolymerTemplateModifications({
4545
console.error(
4646
'[Brave Settings Overrides] Couldn\'t find autoplay settings')
4747
}
48-
else {autoplaySettings.setAttribute(
49-
'label', loadTimeData.getString('siteSettingsAutoplay'))} curChild++
50-
// Google Sign-In feature
51-
const isGoogleSignInFeatureEnabled =
52-
loadTimeData.getBoolean('isGoogleSignInFeatureEnabled')
48+
else {
49+
autoplaySettings.setAttribute(
50+
'label', loadTimeData.getString('siteSettingsAutoplay'))
51+
}
52+
curChild++
53+
// Google Sign-In feature
54+
const isGoogleSignInFeatureEnabled =
55+
loadTimeData.getBoolean('isGoogleSignInFeatureEnabled')
5356
if (isGoogleSignInFeatureEnabled) {
5457
firstPermissionItem.insertAdjacentHTML(
5558
'beforebegin',
@@ -65,9 +68,11 @@ RegisterPolymerTemplateModifications({
6568
console.error(
6669
'[Brave Settings Overrides] Couldn\'t find Google signin settings')
6770
}
68-
else {googleSignInSettings.setAttribute(
69-
'label',
70-
loadTimeData.getString('siteSettingsGoogleSignIn'))} curChild++
71+
else {
72+
googleSignInSettings.setAttribute(
73+
'label', loadTimeData.getString('siteSettingsGoogleSignIn'))
74+
}
75+
curChild++
7176
}
7277
const isNativeBraveWalletEnabled = loadTimeData.getBoolean('isNativeBraveWalletFeatureEnabled')
7378
if (isNativeBraveWalletEnabled) {
@@ -84,6 +89,9 @@ RegisterPolymerTemplateModifications({
8489
if (!ethereumSettings) {
8590
console.error(
8691
'[Brave Settings Overrides] Couldn\'t find Ethereum settings')
92+
} else {
93+
ethereumSettings.setAttribute(
94+
'label', loadTimeData.getString('siteSettingsEthereum'))
8795
}
8896
curChild++
8997
firstPermissionItem.insertAdjacentHTML(

0 commit comments

Comments
 (0)