Skip to content

Fix missing Ethereum permissions header #17390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Fix missing Ethereum permissions header #17390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76a9bb7
Fix formatting
emerick Feb 27, 2023
950441b
Fix missing Ethereum permissions header in settings
emerick Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions browser/resources/settings/brave_overrides/site_details.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,14 @@ RegisterPolymerTemplateModifications({
console.error(
'[Brave Settings Overrides] Couldn\'t find autoplay settings')
}
else {autoplaySettings.setAttribute(
'label', loadTimeData.getString('siteSettingsAutoplay'))} curChild++
// Google Sign-In feature
const isGoogleSignInFeatureEnabled =
loadTimeData.getBoolean('isGoogleSignInFeatureEnabled')
else {
autoplaySettings.setAttribute(
'label', loadTimeData.getString('siteSettingsAutoplay'))
}
curChild++
// Google Sign-In feature
const isGoogleSignInFeatureEnabled =
loadTimeData.getBoolean('isGoogleSignInFeatureEnabled')
if (isGoogleSignInFeatureEnabled) {
firstPermissionItem.insertAdjacentHTML(
'beforebegin',
Expand All @@ -65,9 +68,11 @@ RegisterPolymerTemplateModifications({
console.error(
'[Brave Settings Overrides] Couldn\'t find Google signin settings')
}
else {googleSignInSettings.setAttribute(
'label',
loadTimeData.getString('siteSettingsGoogleSignIn'))} curChild++
else {
googleSignInSettings.setAttribute(
'label', loadTimeData.getString('siteSettingsGoogleSignIn'))
}
curChild++
}
const isNativeBraveWalletEnabled = loadTimeData.getBoolean('isNativeBraveWalletFeatureEnabled')
if (isNativeBraveWalletEnabled) {
Expand All @@ -84,6 +89,9 @@ RegisterPolymerTemplateModifications({
if (!ethereumSettings) {
console.error(
'[Brave Settings Overrides] Couldn\'t find Ethereum settings')
} else {
ethereumSettings.setAttribute(
'label', loadTimeData.getString('siteSettingsEthereum'))
}
curChild++
firstPermissionItem.insertAdjacentHTML(
Expand Down