Skip to content

Crash in rewards tipping banner #17116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

Crash in rewards tipping banner #17116

merged 1 commit into from
Feb 21, 2023

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Feb 8, 2023 •
edited by Miyayes
Loading

Resolves brave/brave-browser#28316
Resolves brave/brave-browser#28088

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

az_recorder_20230221_101919.mp4

@sujitacharya2005 sujitacharya2005 added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 8, 2023
@sujitacharya2005 sujitacharya2005 force-pushed the 28316_Crash_in_rewards_tipping_banner branch 2 times, most recently from b877731 to 0744e50 Compare February 20, 2023 12:10
@sujitacharya2005 sujitacharya2005 added this to the 1.50.x - Nightly milestone Feb 20, 2023
deeppandya
deeppandya approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tapanmodh
tapanmodh approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sujitacharya2005 sujitacharya2005 force-pushed the 28316_Crash_in_rewards_tipping_banner branch from 0744e50 to 2fe8946 Compare February 21, 2023 04:56
@sujitacharya2005 sujitacharya2005 mentioned this pull request Feb 21, 2023
Closed
SergeyZhukovsky
SergeyZhukovsky approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@sujitacharya2005 sujitacharya2005 force-pushed the 28316_Crash_in_rewards_tipping_banner branch from 2fe8946 to b14ab32 Compare February 21, 2023 15:57
@sujitacharya2005 sujitacharya2005 merged commit 9631729 into master Feb 21, 2023
@sujitacharya2005 sujitacharya2005 deleted the 28316_Crash_in_rewards_tipping_banner branch February 21, 2023 16:44
@brave-builds brave-builds mentioned this pull request Feb 28, 2023
Merged
7 tasks
sujitacharya2005 pushed a commit that referenced this pull request Mar 1, 2023
@brave-builds @sujitacharya2005
Uplift of #17116 (squashed) to beta
7b7c934
kjozwiak pushed a commit that referenced this pull request Mar 2, 2023
@brave-builds
Crash in rewards tipping banner (uplift to 1.49.x) (#17408)
5bc971e 
Uplift of #17116 (squashed) to beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeppandya deeppandya deeppandya approved these changes

@tapanmodh tapanmodh tapanmodh approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

Assignees

@sujitacharya2005 sujitacharya2005

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.

Crash in rewards tipping banner Crash on rewards site banner
4 participants
@sujitacharya2005 @deeppandya @tapanmodh @SergeyZhukovsky