Skip to content

Crash in rewards tipping banner #28316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SergeyZhukovsky opened this issue Feb 6, 2023 · 1 comment · Fixed by brave/brave-core#17116
Closed

Crash in rewards tipping banner #28316

SergeyZhukovsky opened this issue Feb 6, 2023 · 1 comment · Fixed by brave/brave-core#17116
Assignees
Labels
crash feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash in GPS on 1.49.81. We need to fix and uplift to the appropriate channel. The problem is that we access native part in onCreate. We should inherit that Activity from AsyncInitializationActivity as we do in other Activities and not from FragmentActivity. Any native calls has to be done in finishNativeInitialization

Crash stack:

Exception java.lang.RuntimeException:
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3780)
  at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3947)
  at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:106)
  at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2325)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loopOnce (Looper.java:210)
  at android.os.Looper.loop (Looper.java:299)
  at android.app.ActivityThread.main (ActivityThread.java:8280)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:576)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1073)
Caused by : VX0
  at org.chromium.base.NativeLibraryLoadedStatus.checkLoaded (NativeLibraryLoadedStatus.java:32)
  at org.chromium.chrome.browser.BraveRewardsNativeWorkerJni.get (BraveRewardsNativeWorkerJni.java:311)
  at org.chromium.chrome.browser.BraveRewardsNativeWorker.Init (BraveRewardsNativeWorker.java:87)
  at org.chromium.chrome.browser.BraveRewardsNativeWorker.getInstance (BraveRewardsNativeWorker.java:74)
  at org.chromium.chrome.browser.BraveRewardsSiteBannerActivity.onCreate (BraveRewardsSiteBannerActivity.java:70)
  at android.app.Activity.performCreate (Activity.java:8163)
  at android.app.Activity.performCreate (Activity.java:8130)
  at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1329)
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3753)
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2023

Going to label this once as QA/No as we'll run through rewards via the manual passes which involves tipping so this will get checked by default. CCing @Uni-verse @GeetaSarvadnya to keep an eye when we're running through rewards tipping. Because this was found via the GPS dashboard, there's no exact STR/Cases that can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants