Skip to content

Commit b877731

Browse files
Crash in rewards tipping banner
1 parent 3fbefb0 commit b877731

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

android/java/AndroidManifest.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize" />
88

99
<activity android:name="org.chromium.chrome.browser.BraveRewardsSiteBannerActivity"
10-
android:theme="@android:style/Theme.Translucent.NoTitleBar"
10+
android:theme="@style/Theme.Chromium.Activity"
1111
android:screenOrientation="sensorPortrait"
1212
tools:ignore="LockedOrientationActivity" />
1313

android/java/org/chromium/chrome/browser/BraveRewardsSiteBannerActivity.java

+13-11
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import org.chromium.base.Log;
1919
import org.chromium.chrome.R;
2020
import org.chromium.chrome.browser.BraveRewardsNativeWorker;
21+
import org.chromium.chrome.browser.init.AsyncInitializationActivity;
2122
import org.chromium.chrome.browser.rewards.BraveRewardsAmountChangeListener;
2223
import org.chromium.chrome.browser.rewards.BraveRewardsBannerInfo;
2324
import org.chromium.chrome.browser.rewards.BraveRewardsCreatorPanelFragment;
@@ -26,9 +27,9 @@
2627
import org.chromium.chrome.browser.rewards.BraveRewardsTipFailureFragment;
2728
import org.chromium.chrome.browser.rewards.BraveRewardsTippingPanelFragment;
2829

29-
public class BraveRewardsSiteBannerActivity
30-
extends FragmentActivity implements BraveRewardsTipConfirmationListener,
31-
BraveRewardsAmountChangeListener, BraveRewardsObserver {
30+
public class BraveRewardsSiteBannerActivity extends AsyncInitializationActivity
31+
implements BraveRewardsTipConfirmationListener, BraveRewardsAmountChangeListener,
32+
BraveRewardsObserver {
3233
private ToggleButton radio_tip_amount[] = new ToggleButton[3];
3334
public static final String TAB_ID_EXTRA = "currentTabId";
3435
public static final String IS_MONTHLY_CONTRIBUTION = "is_monthly_contribution";
@@ -60,10 +61,8 @@ public class BraveRewardsSiteBannerActivity
6061
private static final String TAG = "TippingBanner";
6162

6263
@Override
63-
protected void onCreate(Bundle savedInstanceState) {
64-
65-
//inflate
66-
super.onCreate(savedInstanceState);
64+
protected void triggerLayoutInflation() {
65+
// inflate
6766
setContentView(R.layout.brave_rewards_site_banner);
6867
mIsActivityIsActive = true;
6968
mProgressBar = findViewById(R.id.progressBar);
@@ -73,13 +72,16 @@ protected void onCreate(Bundle savedInstanceState) {
7372
currentTabId_ = IntentUtils.safeGetIntExtra(getIntent(), TAB_ID_EXTRA, -1);
7473
mIsMonthlyContribution =
7574
IntentUtils.safeGetBooleanExtra(getIntent(), IS_MONTHLY_CONTRIBUTION, false);
76-
if (savedInstanceState == null) {
77-
mBraveRewardsNativeWorker.GetPublisherBanner(
78-
mBraveRewardsNativeWorker.GetPublisherId(currentTabId_));
79-
}
75+
mBraveRewardsNativeWorker.GetPublisherBanner(
76+
mBraveRewardsNativeWorker.GetPublisherId(currentTabId_));
8077
clickOnCloseButton();
8178
}
8279

80+
@Override
81+
public boolean shouldStartGpuProcess() {
82+
return true;
83+
}
84+
8385
private void clickOnCloseButton() {
8486
View closeButton = findViewById(R.id.button_close);
8587
closeButton.setOnClickListener((v) -> { finish(); });

0 commit comments

Comments
 (0)