-
Notifications
You must be signed in to change notification settings - Fork 451
Add protoc-gen-validate 1.0.4.bcr.1 #3420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes compatibility with more recent versions of rules_python.
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protoc-gen-validate) have been updated in this PR. Please review the changes. |
@bazel-io skip_check unstable_url |
yea, note that as of bazel 7.4.x you can use a single_module_override to patch MODULE.bazel files to avoid this kinda issue. still good to fix for everyone tho 👍 |
This fixes compatibility with more recent versions of rules_python.
Thanks for the hint. As we are providing an SDK to our users, we are not the root module and therefore cannot use overrides. |
- Based on envoyproxy/envoy#34355 - Requires #3420 and #3423 - Upstreaming target name alignment in #3415 and envoyproxy/envoy#37662 - Issue for patched Protobuf: envoyproxy/envoy#37669
This fixes compatibility with newer versions of rules_python. Same patch was already applied in 1.0.4.bcr.1 (#3420). Also migrate to using overlays instead of a patch.
This fixes compatibility with newer versions of rules_python. Same patch was already applied in 1.0.4.bcr.1 (bazelbuild#3420). Also migrate to using overlays instead of a patch.
This fixes compatibility with more recent versions of rules_python.