Skip to content

Add protoc-gen-validate 1.0.4.bcr.1 #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

mering
Copy link
Contributor

@mering mering commented Dec 14, 2024

This fixes compatibility with more recent versions of rules_python.

This fixes compatibility with more recent versions of rules_python.
@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protoc-gen-validate) have been updated in this PR. Please review the changes.

@mering
Copy link
Contributor Author

mering commented Dec 14, 2024

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Dec 14, 2024
@mering
Copy link
Contributor Author

mering commented Dec 14, 2024

@keith patching the old version until #3414 is figured out. The current version 1.0.4 on BCR is not compatible with recent rules_python version (still uses name instead of hub_name for pip dependencies).

@keith
Copy link
Member

keith commented Dec 14, 2024

yea, note that as of bazel 7.4.x you can use a single_module_override to patch MODULE.bazel files to avoid this kinda issue. still good to fix for everyone tho 👍

@keith keith enabled auto-merge (squash) December 14, 2024 19:17
@keith keith merged commit 08b05bb into bazelbuild:main Dec 14, 2024
15 checks passed
@mering mering deleted the protoc-gen-validate-1.0.4.bcr.1 branch December 14, 2024 19:17
mering added a commit to mering/bazel-central-registry that referenced this pull request Dec 15, 2024
This fixes compatibility with more recent versions of rules_python.
@mering
Copy link
Contributor Author

mering commented Dec 15, 2024

yea, note that as of bazel 7.4.x you can use a single_module_override to patch MODULE.bazel files to avoid this kinda issue. still good to fix for everyone tho 👍

Thanks for the hint. As we are providing an SDK to our users, we are not the root module and therefore cannot use overrides.

@mering mering mentioned this pull request Dec 15, 2024
meteorcloudy pushed a commit that referenced this pull request Dec 19, 2024
- Based on envoyproxy/envoy#34355
- Requires
#3420 and
#3423
- Upstreaming target name alignment in
#3415 and
envoyproxy/envoy#37662
- Issue for patched Protobuf:
envoyproxy/envoy#37669
meteorcloudy pushed a commit that referenced this pull request Mar 10, 2025
This fixes compatibility with newer versions of rules_python. Same patch
was already applied in 1.0.4.bcr.1 (#3420).

Also migrate to using overlays instead of a patch.
feuerste pushed a commit to feuerste/bazel-central-registry that referenced this pull request Mar 18, 2025
This fixes compatibility with newer versions of rules_python. Same patch
was already applied in 1.0.4.bcr.1 (bazelbuild#3420).

Also migrate to using overlays instead of a patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants