Skip to content

Add protoc-gen-validate 1.2.1.bcr.1 #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mering
Copy link
Contributor

@mering mering commented Mar 10, 2025

This fixes compatibility with newer versions of rules_python. Same patch was already applied in 1.0.4.bcr.1 (#3420).

Also migrate to using overlays instead of a patch.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protoc-gen-validate) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@mering
Copy link
Contributor Author

mering commented Mar 10, 2025

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Mar 10, 2025
This fixes compatibility with newer versions of rules_python.
Same patch was already applied in 1.0.4.bcr.1.

Also migrate to using overlays instead of a patch.
@mering mering force-pushed the protoc-gen-validate-1.2.1.bcr.1 branch from aeb5248 to 1a40408 Compare March 10, 2025 15:08
@meteorcloudy
Copy link
Member

Same patch was already applied in 1.0.4.bcr.1 (#3420).

Should we upstream the patch to avoid needing to have a bcr patch version for every version?

@meteorcloudy meteorcloudy merged commit eb0fdf4 into bazelbuild:main Mar 10, 2025
18 checks passed
@mering
Copy link
Contributor Author

mering commented Mar 10, 2025

Same patch was already applied in 1.0.4.bcr.1 (#3420).

Should we upstream the patch to avoid needing to have a bcr patch version for every version?

@meteorcloudy upstream does not have a MODULE.bazel file.

@mering mering deleted the protoc-gen-validate-1.2.1.bcr.1 branch March 10, 2025 15:34
feuerste pushed a commit to feuerste/bazel-central-registry that referenced this pull request Mar 18, 2025
This fixes compatibility with newer versions of rules_python. Same patch
was already applied in 1.0.4.bcr.1 (bazelbuild#3420).

Also migrate to using overlays instead of a patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants