Improve opentelemetry-proto #3415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bazel-io skip_check unstable_url |
|
Hello @keith, modules you maintain (opentelemetry-proto) have been updated in this PR. Please review the changes. |
bazel-io
added
the
skip-url-stability-check
mering
force-pushed
the
improve-opentelemetry-proto
branch
from
6975e1f to
c823bd8
Compare
mering
force-pushed
the
improve-opentelemetry-proto
branch
from
c823bd8 to
2da4492
Compare
keith
previously approved these changes
Dec 14, 2024
|
ci issue |
mering
force-pushed
the
improve-opentelemetry-proto
branch
from
2da4492 to
613198d
Compare
bazel-io
dismissed
keith’s stale review
Require module maintainers' approval for newly pushed changes.
|
@keith can you trigger the CI again please? |
mering
force-pushed
the
improve-opentelemetry-proto
branch
from
613198d to
06236b4
Compare
|
@keith same here, one more time please. |
|
done |
Add Python and Go proto bindings
mering
force-pushed
the
improve-opentelemetry-proto
branch
from
06236b4 to
f48a813
Compare
|
@keith again please? Thx. |
keith
approved these changes
Dec 14, 2024
This was referenced Dec 15, 2024
Merged
meteorcloudy
pushed a commit
that referenced
this pull request
Dec 19, 2024
- Based on envoyproxy/envoy#34355 - Requires #3420 and #3423 - Upstreaming target name alignment in #3415 and envoyproxy/envoy#37662 - Issue for patched Protobuf: envoyproxy/envoy#37669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Python and Go proto bindings