fix(autoware_simple_object_merger): templatize simple object merger #10785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
a-maumau
force-pushed
the
mau/feat/perception/simple_object_merger/templatize
branch
from
cdfed71 to
31a8c49
Compare
Signed-off-by: a-maumau <[email protected]>
Signed-off-by: a-maumau <[email protected]>
a-maumau
force-pushed
the
mau/feat/perception/simple_object_merger/templatize
branch
from
31a8c49 to
9bba977
Compare
a-maumau
changed the title
a-maumau
requested review from
scepter914,
technolojin and
YoshiRi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR templatizes
autoware_simple_object_mergerto support bothDetectedObjectsandTrackedObjects messages.For the
TrackedObjects, if the UUID collides, it will generate a new UUID and map to the new UUID.Mapping get removed when the last usage was older than the
uuid_mapping_cleanup_threshold.Note
Node name has been changed.
Related links
Parent Issue:
How was this PR tested?
Test with the test in this PR and Autoware's sample rosbag.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
Node name of simple object merger has been changed.