Clean up to remove pyaedt references / cfg / ... #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMoraisAnsys
force-pushed
the
refact/update_repo
branch
from
689ef9a to
c5aa6dd
Compare
Use different conftest files for legacy and grpc testing. Fixture used to instanciate an edb app have been renamed depending on which back is tested: legacy_edb_app or grpc_edb_app.
The clean up includes the removal of almost every reference to pyaedt. Some of them were kept as it could make sens for current use or there was no way to do otherwise: - src/pyedb/legacy/clr_module.py (path to pyaedt for loading stuff) - src/pyedb/edb_core/edb_data/simulation_configuration.py (multiple method optional arguments: use_pyaedt_cutout) - src/pyedb/edb.py (multiple method optional arguments: use_pyaedt_extent, use_pyaedt_cutout, use_pyaedt_extent_computing) - src/pyedb/edb_core/nets.py (reference to environment variable PYAEDT_SERVER_AEDT_PATH) - src/pyedb/edb_core/dotnet.py (reference to environment variable PYAEDT_SERVER_AEDT_PATH) The rest of the modification were performed to increase the project overall quality.
SMoraisAnsys
force-pushed
the
refact/update_repo
branch
from
c5aa6dd to
afb0285
Compare
SMoraisAnsys
requested review from
MaxJPRey,
maxcapodi78 and
Samuelopez-ansys
as code owners
SMoraisAnsys
requested review from
svandenb-dev
and removed request for
maxcapodi78,
Samuelopez-ansys and
MaxJPRey
Currently these tests break the CI. Moreover, the unit tests are not working yet and system tests are simple copy paste from the legacy folder.
Importing EdbGrpc (from pyedb.grpc.edb import EdbGrpc) raises an ImportException. To avoid breaking the CI: - this call has been moved at fixture call (see add_grpc_edb) - grpc system tests are marked with xfail on ImportException
Note Seems like a copy paste error from the grpc implementation
SMoraisAnsys
force-pushed
the
refact/update_repo
branch
from
8f411a3 to
a8a3aaf
Compare
svandenb-dev
added a commit
that referenced
this pull request
Mar 13, 2025
* test #47 done * test #48 done * test #49 done * test #49 done * test #50 done * test #51 done * test #52 done * test #53 done * test #54 done * test #55 done * test #56 done * test #57 done * test #58 done * test #59 done * test #60 done * test #61 done * test #62 done * test #62 done * test #63 done * test #64 done * test #65 done * test #66 done * test #67 done * test #68 done * test #69 done * test #70 done * test #71 done * test #72 done * test #73 done * test #74 done * test #75 done * test #75 done * test #76 done * test #77 done * test #78 done * test #79 done * test #80 done * test #81 done * test #82 done * test #83 done * test #83 done * test #84 done * test #85 done * test #86 done * test #87 done * test #88 done * test #89 done * test #90 done * test #91 done * test #92 done * test #93 done * test #94 done * test #95 done * test #96 done * test #96 done * material done * test #97 * test #98 * test #98 * test #100 * test #101 * rpc init * rpc server * rpc server * rpc server * rpc server * added new method to plot * test #101 * layout plot updated * refactor naming * test 104 * Added new common class and refactored Plot method * Added new common class and refactored Plot method * Added new common class and refactored Plot method * Fixed UT * test 105 * test 110 * test #112 * test #113 * test #114 * test #ipc * ipc grpc * added requirements * modeler * added requirements * added requirements * REFACTOR: Material implementation * test modeler duplicate * test modeler #2 * test modeler #arbitrary waveports * test modeler #arbitrary waveports * test modeler #4 * test modeler #5 * test modeler #6 * test modeler #7 * test materials completed * test materials completed * test materials completed * mesh op fix * custom cutout 0 fixed * component * test #110 * test #111 * test #112 * test #113 * test #114 * test #115 * test #116 * test #117 * test #118 * test #119 * test #120 * test #121 * test #120 * test #121 * test #130 * test #131 * test #132 * test #133 * test #134 * test #134 * new feature via clustering * edbcore doc removing * edbcore doc removing * bug fix * grpc * grpc * Fixed grpc layer construction * grpc * grpc * grpc * edb caching * revert * revert * ipc caching * ipc caching * ipc caching * test modeler * edb grpc * doc string * renaming EdbGrpc to Edb * doc string * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring * doc refactoring all ref pass * doc refactoring all ref pass * doc refactoring all ref pass * doc refactoring all ref pass * doc refactoring all ref pass * doc refactoring all ref pass * doc refactoring * bundle terminal docstring * terminal docstring * terminal docstring * def docstring * def docstring * material docstring * docstring * geometry docstring * component.py docstring * docstring * docstring * doc string * doc string * doc string * ports doc string * primitive.py doc string * simulation_setup.py doc string * utility.py doc string * example repo doc string * removing caching * rpc_session.py * grpc optim speed * fixes for test_edb.py * fixes for test_edb.py part 2 * adding grpc tag * doc removed * doc removed * .NET doc recovered * cicd * grpc markers * grpc markers * grpc markers * grpc markers * grpc markers * doc fix * pytest mark * pytest mark * pytest mark * cicd * primitive aedt name --------- Co-authored-by: maxcapodi78 <Shark78> Co-authored-by: mcapodif <[email protected]> Co-authored-by: Sebastien Morais <[email protected]> Co-authored-by: dmiller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should cut almost all non needed references to pyaedt.
Some of them are kept on purpose or because I'm not sure whether we should keep them or not, see :
@svandenb-dev I'll let you decide on what to do with these list of files.