Skip to content

FEAT: Grpc transition speed optimization #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 375 commits into from
Mar 13, 2025
Merged

FEAT: Grpc transition speed optimization #1010

merged 375 commits into from
Mar 13, 2025

Conversation

svandenb-dev
Copy link
Collaborator

PyEDB gRPC

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.97908% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.58%. Comparing base (bf6bed1) to head (0991a83).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
- Coverage   82.85%   82.58%   -0.27%     
==========================================
  Files         161      161              
  Lines       22087    22049      -38     
==========================================
- Hits        18300    18209      -91     
- Misses       3787     3840      +53
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hui-zhou-a
hui-zhou-a previously approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

SMoraisAnsys
SMoraisAnsys approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I didn't review the grpc modification. It shouldn't be used by any user atm.
The changes in CICD are fine.

@svandenb-dev svandenb-dev linked an issue Mar 13, 2025 that may be closed by this pull request
ROADMAP: PyEDB gRPC migration #921
Closed
@svandenb-dev svandenb-dev merged commit cd953ee into main Mar 13, 2025
29 checks passed
@svandenb-dev svandenb-dev deleted the grpc-transition-caching-optim branch March 13, 2025 12:41
@svandenb-dev svandenb-dev mentioned this pull request Mar 17, 2025
Draft
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@hui-zhou-a hui-zhou-a hui-zhou-a left review comments

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

Assignees
No one assigned
Labels
ci/cd dependencies Related with project dependencies documentation Improvements or additions to documentation grpc-transition Changes that need to be included in gRPC transition maintenance Package and maintenance related testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROADMAP: PyEDB gRPC migration
6 participants
@svandenb-dev @codecov-commenter @hui-zhou-a @SMoraisAnsys @maxcapodi78 @drewm102