Skip to content

FIX: Fix spisim.py in compute_erl #5976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2025
Merged

FIX: Fix spisim.py in compute_erl #5976

merged 4 commits into from
Mar 28, 2025

Conversation

maxcapodi78
Copy link
Collaborator

Description

Added environment variable to fix Spisim error when multiple releases where present in machine.
Fixed compute_erl

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.08%. Comparing base (8239f21) to head (9e886e1).
Report is 4 commits behind head on main.

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5976      +/-   ##
==========================================
+ Coverage   85.06%   85.08%   +0.01%     
==========================================
  Files         163      163              
  Lines       62780    62783       +3     
==========================================
+ Hits        53401    53416      +15     
+ Misses       9379     9367      -12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 28, 2025 11:21
@Samuelopez-ansys Samuelopez-ansys merged commit 292a2ad into main Mar 28, 2025
46 of 47 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the spisim_fixes branch March 28, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants