Skip to content

FIX: Fix spisim.py in compute_erl #5976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2025
Merged

FIX: Fix spisim.py in compute_erl #5976

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dd1032
Fix spisim.py in compute_erl
maxcapodi78 Mar 28, 2025
b5db523
chore: adding changelog file 5976.fixed.md [dependabot-skip]
pyansys-ci-bot Mar 28, 2025
98cfb3a
Added impedance to TDR Analysis
maxcapodi78 Mar 28, 2025
9e886e1
Merge remote-tracking branch 'origin/spisim_fixes' into spisim_fixes
maxcapodi78 Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/5976.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix spisim.py in compute_erl
2 changes: 1 addition & 1 deletion src/ansys/aedt/core/visualization/post/compliance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,7 @@
if not isinstance(trace_pin[0], int):
try:
ports = list(_design.excitation_names)
thrus4p = [ports.index(i) for i in trace_pin]
thrus4p = [ports.index(i) + 1 for i in trace_pin]

Check warning on line 869 in src/ansys/aedt/core/visualization/post/compliance.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/aedt/core/visualization/post/compliance.py#L869 

Added line #L869 was not covered by tests
trace_pin = thrus4p
except IndexError:
_design.logger.error("Port not found.")
Expand Down
1 change: 1 addition & 0 deletions src/ansys/aedt/core/visualization/post/spisim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def __init__(self, touchstone_file=""):
self.desktop_install_dir = os.environ[env_value(settings.aedt_version)]
else:
self.desktop_install_dir = os.environ[env_value(aedt_versions.current_version)]
os.environ["ANSYSEM_ROOT_PATH"] = self.desktop_install_dir
self.logger = settings.logger
self._working_directory = ""

Expand Down