Temporarily disable required reviews on Community manifest-only connectors #44004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
@ChristoGrab I'm not sure this change is required.
The "Required reviews" check is not blocking auto-merge as only required CI checks have to be 🟢 to merge the PR.
|
@alafanechere Gave it a try on a number of PRs. I added the auto-merge label and ran the CI again, but they're still pending on the review. I think this might be because the Github Action we use to assign reviewers always marks them as required? Unless I'm just missing a step, which is always a distinct possibility 😅 |
erohmensing
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to allow automerging of manifest-only migrations that are passing the pipeline, we need to temporarily disable the required review that is assigned to the Marketplace team for all manifest-only community connectors.
Resolves #9210
How
Comments out the required reviewers for Community manifest-only connectors until we have pushed through the migration wave.
Issue to track this change and remind us to revert when ready.
User Impact
None, temporary measure to unblock automerging on internal PRs.
Can this PR be safely reverted and rolled back?