Skip to content

Temporarily disable required reviews on Community manifest-only connectors #44004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Temporarily disable required reviews on Community manifest-only connectors #44004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
207f1cd
chore: temporarily disable required reviews on manifest-only connectors
ChristoGrab Aug 13, 2024
27d1832
chore: format
ChristoGrab Aug 13, 2024
e500372
Update README.md
ChristoGrab Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airbyte-ci/connectors/connector_ops/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ poetry run pytest
```

## Changelog

- 0.7.1: Temporarily disable required reviewers for community manifest-only connectors.
- 0.7.0: Added required reviewers for manifest-only connector changes/additions.
- 0.6.1: Simplified gradle dependency discovery logic.
- 0.6.0: Added manifest-only build.
Expand Down
13 changes: 8 additions & 5 deletions airbyte-ci/connectors/connector_ops/connector_ops/required_reviewer_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,14 @@ def find_mandatory_reviewers() -> List[Dict[str, Union[str, Dict[str, List]]]]:
"teams": list(CERTIFIED_MANIFEST_ONLY_CONNECTOR_REVIEWERS),
"is_required": find_changed_manifest_only_connectors(support_level="certified"),
},
{
"name": "Manifest-only community connectors",
"teams": list(COMMUNITY_MANIFEST_ONLY_CONNECTOR_REVIEWERS),
"is_required": find_changed_manifest_only_connectors(support_level="community"),
},
# TODO: We are disabling this requirement to unblock automerging of the manifest-only migrations.
# We should re-enable this requirement when we have migrated our existing connectors to manifest-only
# and are ready to enforce reviews for community connectors again.
# {
# "name": "Manifest-only community connectors",
# "teams": list(COMMUNITY_MANIFEST_ONLY_CONNECTOR_REVIEWERS),
# "is_required": find_changed_manifest_only_connectors(support_level="community"),
# },
]

return [{"name": r["name"], "teams": r["teams"]} for r in requirements if r["is_required"]]
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/connector_ops/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "connector_ops"
version = "0.7.0"
version = "0.7.1"
description = "Packaged maintained by the connector operations team to perform CI for connectors"
authors = ["Airbyte <[email protected]>"]

Expand Down
5 changes: 3 additions & 2 deletions airbyte-ci/connectors/connector_ops/tests/test_required_reviewer_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,9 @@ def test_find_mandatory_reviewers_no_tracked_changed(capsys, not_tracked_change_
check_review_requirements_file(capsys, not_tracked_change_expected_team)


def test_find_reviewers_manifest_only_community_connector(capsys, test_community_manifest_only_connector_expected_team):
check_review_requirements_file(capsys, test_community_manifest_only_connector_expected_team)
# TODO: Re-enable this test when we have migrated our existing connectors to manifest-only and no longer need to automerge
# def test_find_reviewers_manifest_only_community_connector(capsys, test_community_manifest_only_connector_expected_team):
# check_review_requirements_file(capsys, test_community_manifest_only_connector_expected_team)


def test_find_reviewers_manifest_only_certified_connector(capsys, test_certified_manifest_only_connector_expected_team):
Expand Down
Loading