Skip to content

Commit 9330801

Browse files
authored
Temporarily disable required reviews on Community manifest-only connectors (#44004)
1 parent 34f58fa commit 9330801

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

airbyte-ci/connectors/connector_ops/README.md

+2
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ poetry run pytest
3737
```
3838

3939
## Changelog
40+
41+
- 0.7.1: Temporarily disable required reviewers for community manifest-only connectors.
4042
- 0.7.0: Added required reviewers for manifest-only connector changes/additions.
4143
- 0.6.1: Simplified gradle dependency discovery logic.
4244
- 0.6.0: Added manifest-only build.

airbyte-ci/connectors/connector_ops/connector_ops/required_reviewer_checks.py

+8-5
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,14 @@ def find_mandatory_reviewers() -> List[Dict[str, Union[str, Dict[str, List]]]]:
4444
"teams": list(CERTIFIED_MANIFEST_ONLY_CONNECTOR_REVIEWERS),
4545
"is_required": find_changed_manifest_only_connectors(support_level="certified"),
4646
},
47-
{
48-
"name": "Manifest-only community connectors",
49-
"teams": list(COMMUNITY_MANIFEST_ONLY_CONNECTOR_REVIEWERS),
50-
"is_required": find_changed_manifest_only_connectors(support_level="community"),
51-
},
47+
# TODO: We are disabling this requirement to unblock automerging of the manifest-only migrations.
48+
# We should re-enable this requirement when we have migrated our existing connectors to manifest-only
49+
# and are ready to enforce reviews for community connectors again.
50+
# {
51+
# "name": "Manifest-only community connectors",
52+
# "teams": list(COMMUNITY_MANIFEST_ONLY_CONNECTOR_REVIEWERS),
53+
# "is_required": find_changed_manifest_only_connectors(support_level="community"),
54+
# },
5255
]
5356

5457
return [{"name": r["name"], "teams": r["teams"]} for r in requirements if r["is_required"]]

airbyte-ci/connectors/connector_ops/tests/test_required_reviewer_checks.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,9 @@ def test_find_mandatory_reviewers_no_tracked_changed(capsys, not_tracked_change_
113113
check_review_requirements_file(capsys, not_tracked_change_expected_team)
114114

115115

116-
def test_find_reviewers_manifest_only_community_connector(capsys, test_community_manifest_only_connector_expected_team):
117-
check_review_requirements_file(capsys, test_community_manifest_only_connector_expected_team)
116+
# TODO: Re-enable this test when we have migrated our existing connectors to manifest-only and no longer need to automerge
117+
# def test_find_reviewers_manifest_only_community_connector(capsys, test_community_manifest_only_connector_expected_team):
118+
# check_review_requirements_file(capsys, test_community_manifest_only_connector_expected_team)
118119

119120

120121
def test_find_reviewers_manifest_only_certified_connector(capsys, test_certified_manifest_only_connector_expected_team):

0 commit comments

Comments
 (0)