-
Notifications
You must be signed in to change notification settings - Fork 176
Install Windows SDK >= 18362 to fix compilation of UE-4.27 #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b79f6e9
to
edece40
Compare
Veeeery interesting...
And yep, it has successfully compiled the whole editor before failing. |
So, I'm dropping attempts to install Windows SDK via VS Build Tools installer and instead trying to use Chocolatey for that. There are two reasons for that move:
|
edece40
to
6972d00
Compare
6972d00
to
8300b69
Compare
For the reference: after this change, we are installing exactly 18362 as of today. |
@rem We're installing Windows SDK here instead of through VS installer for several reasons: | ||
@rem 1. pdbcopy.exe is needed for creating an Installed Build of the Engine and it isn't installed through VS | ||
@rem 2. UE-4.27 failts to compile against Windows SDK older than 18362 and 18362 isn't available through VS2017 installer | ||
choco install -y choco-cleaner curl vcredist-all windows-sdk-10.1 || goto :error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a floating version target. Would it be better to explicitly use windows-sdk-10-version-1903-all
, which is currently the same version but passes /Features +
to the installer, perhaps it installs more stuff?). That version won't change if the windows-sdk-10.1
maintainer decides to update to a new version again.
That said, if the version floats forward, that shouldn't be a problem for us, new SDKs can generally target older versions, and I doubt UE4 is using any runtime support that's even Windows 10-specific on the Windows target. And windows-sdk-10.1
currently points at the 2019 SDK release, so perhaps it won't float forward (or is abandoned), as it hasn't picked up the 2004 or 2104 SDKs.
(Oh no, the Windows Server 2022-paired SDK release is "2104". I can't even...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
@rem We're installing Windows SDK here instead of through VS installer for several reasons: | ||
@rem 1. pdbcopy.exe is needed for creating an Installed Build of the Engine and it isn't installed through VS | ||
@rem 2. UE-4.27 failts to compile against Windows SDK older than 18362 and 18362 isn't available through VS2017 installer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo failts
.
This change doesn't work as-is. UE-4.23 needs patching. See #192 (comment) |
Closing, we're going #195 route instead. |
resolves #192
Not tested yet, this will take a while.