Skip to content

Install Windows SDK >= 18362 when using VS2019 to fix compilation of UE-4.27.0 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

slonopotamus
Copy link
Collaborator

resolves #192


This is an alternative to #193. See discussion in #192.

P.S. Testing is not finished yet.

Copy link
Collaborator

@TBBle TBBle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, users may want the SDK version to be configurable. But not worth doing yet.

I like this approach, the only risk I see is if a project is using VS2019-incompatible code in their own source in a UE 4.27 project. That'd require a pretty complicated setup to work locally, and unless we find a real person doing this, it's not worth trying to complicate things here.

@TBBle
Copy link
Collaborator

TBBle commented Sep 2, 2021

Should we also implement MaxSupportedUnreal to go with MinSupportedUnreal?

Or is that too restrictive given both 4.27.1, and the possibility to locally patch 4.27.0 to work with the old SDK and hence support the VS2017 pre-reqs.

I've just realised that (from brief code-inspection) we don't block UE5 with VS2017 either.

@slonopotamus
Copy link
Collaborator Author

slonopotamus commented Sep 2, 2021

Should we also implement MaxSupportedUnreal to go with MinSupportedUnreal?

We should at one point, but not yet. UE5EA can only currently be built as a "custom version", so we effectively treat its version string as an opaque identifier and cannot do conditions with it.

@slonopotamus
Copy link
Collaborator Author

slonopotamus commented Sep 6, 2021

I've successfully build 4.27.0 and 5.0EA2 using these changes, seems good enough to merge. Note that I used --exclude ddc to avoid hitting #196. That thing will be fixed in a separate PR.

@slonopotamus slonopotamus merged commit 62d0e00 into adamrehn:master Sep 6, 2021
@slonopotamus slonopotamus deleted the ue-4.27-fix-v2 branch September 6, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants