Skip to content

style: Adding extra space to the application opening tag #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

MrCsabaToth
Copy link
Contributor

and wearable meta data in AndroidManifest.xml templates. Fixes #125

Description

Discovered a missing space ahead of the <application in the AndroidManifest.xml. It affected creation of Flutter app (create flutter_app), and upon code inspection I also saw the same pattern in Flame Game and Flutter Plugin creation. Besides that towards the end of the Wear app creation manifest had missing single spaces for the com.google.android.wearable.standalone meta-data tag.

Ref VeryGoodOpenSource/very_good_cli#1067 and VeryGoodOpenSource/very_good_cli#1066

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

and wearable meta data in AndroidManifest.xml templates
@MrCsabaToth MrCsabaToth requested a review from a team as a code owner June 15, 2024 23:24
Copy link
Member

@wolfenrain wolfenrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typical off by one mistake! LGTM

@alestiago alestiago added this pull request to the merge queue Jun 19, 2024
Merged via the queue into VeryGoodOpenSource:main with commit dc0cd55 Jun 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

style: AndroidManifest.xml's '<application' opening tag is indented by 3 spaces instead of 4
3 participants