Skip to content

style: Adding extra space to the application opening tag #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

MrCsabaToth
Copy link

and wearable meta data in AndroidManifest.xml templates. Fixes #1066

Status

READY

Description

Discovered a missing space ahead of the <application in the AndroidManifest.xml. It affected creation of Flutter app (create flutter_app), and upon code inspection I also saw the same pattern in Flame Game and Flutter Plugin creation. Besides that towards the end of the Wear app creation manifest had missing single spaces for the com.google.android.wearable.standalone meta-data tag.

I added the spaces and re-base64-encoded the content.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

and wearable meta data in AndroidManifest.xml templates
@MrCsabaToth MrCsabaToth requested a review from a team as a code owner June 14, 2024 18:40
@MrCsabaToth MrCsabaToth changed the title Adding extra space to the application opening tag fix: Adding extra space to the application opening tag Jun 14, 2024
@MrCsabaToth MrCsabaToth changed the title fix: Adding extra space to the application opening tag style: Adding extra space to the application opening tag Jun 14, 2024
@alestiago
Copy link
Contributor

alestiago commented Jun 15, 2024

Hi @MrCsabaToth ! Thanks for your Pull Request!

Updating the bundles manually is not something we do, template code is available at very_good_templates (hence, I'll be closing this Pull Request). Can you raise your changes over there instead?

Once those changes land in very_good_templates the bundles will be updated by a Bot (you don't need to worry about this).

If you run into any issues I recommend reading the available CONTRIBUTING files or raising any questions so we can help you get the PR landed!

Again, thank you for the initiative, attitude and contribution! 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

style: AndroidManifest.xml's '<application' opening tag is indented by 3 spaces instead of 4
2 participants