Skip to content

style: AndroidManifest.xml's '<application' opening tag is indented by 3 spaces instead of 4 #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrCsabaToth opened this issue Jun 14, 2024 · 2 comments
Labels
style Changes that do not affect the meaning of the code

Comments

@MrCsabaToth
Copy link

Description
The generated AndroidManfiest.xml has one less space for the indentation of the <application opening tag, whereas the </application> closing tag has the proper four spaces.

Steps To Reproduce

  1. very_good create flutter_app my_app
  2. cd my_app/android/src/main/
  3. cat AndroidManfiest.xml
  4. 3rd line is the opening tag

Expected Behavior
Both the opening and the closing tag would have four spaces of indentation

Exhibit

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.example.verygoodcore.my_app">
   <application
        android:label="${appName}"
        android:name="${applicationName}"
        android:icon="@mipmap/ic_launcher">
        <activity
            android:name=".MainActivity"
            android:exported="true"
            android:launchMode="singleTask"
            android:theme="@style/LaunchTheme"
            android:configChanges="orientation|keyboardHidden|keyboard|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"
            android:hardwareAccelerated="true"
            android:windowSoftInputMode="adjustResize">
            <!-- Specifies an Android theme to apply to this Activity as soon as
                 the Android process has started. This theme is visible to the user
                 while the Flutter UI initializes. After that, this theme continues
                 to determine the Window background behind the Flutter UI. -->
            <meta-data
              android:name="io.flutter.embedding.android.NormalTheme"
              android:resource="@style/NormalTheme"
              />            
            <intent-filter>
                <action android:name="android.intent.action.MAIN"/>
                <category android:name="android.intent.category.LAUNCHER"/>
            </intent-filter>
        </activity>
        <!-- Don't delete the meta-data below.
             This is used by the Flutter tool to generate GeneratedPluginRegistrant.java -->
        <meta-data
            android:name="flutterEmbedding"
            android:value="2" />
    </application>
</manifest>

Additional Context
I'll try to craft a PR.

@MrCsabaToth MrCsabaToth added the bug Something isn't working as expected label Jun 14, 2024
@alestiago alestiago added refactor A code change that neither fixes a bug nor add a feature style Changes that do not affect the meaning of the code and removed bug Something isn't working as expected refactor A code change that neither fixes a bug nor add a feature labels Jun 14, 2024
@alestiago alestiago changed the title fix: AndroidManifest.xml's '<application' opening tag is indented by 3 spaces instead of 4 style: AndroidManifest.xml's '<application' opening tag is indented by 3 spaces instead of 4 Jun 14, 2024
@MrCsabaToth
Copy link
Author

The Flame Game and Flutter Plugin creation is affected as well, plus the Wear app creation had a different similar (one space missing) indentation for the com.google.android.wearable.standalone meta-data tag, the PR addresses those.

@tomarra
Copy link
Contributor

tomarra commented Jun 18, 2024

This got moved over to VeryGoodOpenSource/very_good_templates#125 so closing this out as won't fix

@tomarra tomarra closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in VGV Open Source 🦄 🧙🌟 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style Changes that do not affect the meaning of the code
Projects
Development

Successfully merging a pull request may close this issue.

3 participants