-
Notifications
You must be signed in to change notification settings - Fork 33
added Jaeger 22 samples #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example review
Need to update changelog once new structure in place |
James to check why libraries table broken once release is done |
ancientsinglegenome-hostassociated/libraries/ancientsinglegenome-hostassociated_libraries.tsv
Outdated
Show resolved
Hide resolved
…me-hostassociated_libraries.tsv Co-authored-by: James A. Fellows Yates <[email protected]>
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
Attempting again to commit suggestions and making pull request for correction. Not entirely sure about which boxed to tick. |
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SRR numbers are duplicated across the two libraries, body210_B should be: SRR17499018
(the URLs are correct though :))
I also make a suggestion which I forgot about which is the URL formatting (we don't keep the ftp://
.
And finally - the one thing we didn't get around to talking about is the CHANGELOG, where we record each new publication. You will need to update this to under the unreleased
section, then the header and subsection: added, single-genome asscociated (look at the previous releases for examples).
Jager2022 2022 10.1016/j.tube.2022.102181 body_210 SRA PRJNA795622 SRS11554883 body210_A double Phusion Hot Start High-Fidelity DNA none Illumina HiSeq X PAIRED WGS 58414020 SRR17499019 fastq_all ftp://ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/019/SRR17499019/SRR17499019_1.fastq.gz;ftp://ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/019/SRR17499019/SRR17499019_2.fastq.gz 64c07f9194159d6ac459cb1d89e3032d;3dc6ad3a84132fff1013c008cc52da31 3941440515;3753166391 | ||
Jager2022 2022 10.1016/j.tube.2022.102181 body_210 SRA PRJNA795622 SRS11554883 body210_B double Phusion Hot Start High-Fidelity DNA none Illumina HiSeq X PAIRED WGS 9768947 SRR17499019 fastq_all ftp://ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/018/SRR17499018/SRR17499018_1.fastq.gz;ftp://ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/018/SRR17499018/SRR17499018_2.fastq.gz 5f9ad49d7787d1857b096dc6a27e1380;2a66ad5a28fe0f553c6a4b8e865e0e6e 654630901;627204826 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jager2022 2022 10.1016/j.tube.2022.102181 body_210 SRA PRJNA795622 SRS11554883 body210_A double Phusion Hot Start High-Fidelity DNA none Illumina HiSeq X PAIRED WGS 58414020 SRR17499019 fastq_all ftp://ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/019/SRR17499019/SRR17499019_1.fastq.gz;ftp://ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/019/SRR17499019/SRR17499019_2.fastq.gz 64c07f9194159d6ac459cb1d89e3032d;3dc6ad3a84132fff1013c008cc52da31 3941440515;3753166391 | |
Jager2022 2022 10.1016/j.tube.2022.102181 body_210 SRA PRJNA795622 SRS11554883 body210_B double Phusion Hot Start High-Fidelity DNA none Illumina HiSeq X PAIRED WGS 9768947 SRR17499019 fastq_all ftp://ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/018/SRR17499018/SRR17499018_1.fastq.gz;ftp://ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/018/SRR17499018/SRR17499018_2.fastq.gz 5f9ad49d7787d1857b096dc6a27e1380;2a66ad5a28fe0f553c6a4b8e865e0e6e 654630901;627204826 | |
Jager2022 2022 10.1016/j.tube.2022.102181 body_210 SRA PRJNA795622 SRS11554883 body210_A double Phusion Hot Start High-Fidelity DNA none Illumina HiSeq X PAIRED WGS 58414020 SRR17499019 fastq_all ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/019/SRR17499019/SRR17499019_1.fastq.gz;ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/019/SRR17499019/SRR17499019_2.fastq.gz 64c07f9194159d6ac459cb1d89e3032d;3dc6ad3a84132fff1013c008cc52da31 3941440515;3753166391 | |
Jager2022 2022 10.1016/j.tube.2022.102181 body_210 SRA PRJNA795622 SRS11554883 body210_B double Phusion Hot Start High-Fidelity DNA none Illumina HiSeq X PAIRED WGS 9768947 SRR17499018 fastq_all ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/018/SRR17499018/SRR17499018_1.fastq.gz;ftp.sra.ebi.ac.uk/vol1/fastq/SRR174/018/SRR17499018/SRR17499018_2.fastq.gz 5f9ad49d7787d1857b096dc6a27e1380;2a66ad5a28fe0f553c6a4b8e865e0e6e 654630901;627204826 |
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
committing suggestions, not done yet with all
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
Corrected the entries. Now trying to understand the CHANGELOG |
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
ancientMetagenomeDirCheck, version 1.3 Ancient Metagenome Host Associated SamplesChecking Ancient Single Genome Host Associated SamplesChecking Ancient Metagenome Environmental SamplesChecking Ancient Metagenome Host Associated LibrariesChecking Ancient Single Genome Host Associated LibrariesChecking Ancient Metagenome Environmental LibrariesChecking |
Pull Request
This PR is for a
For the following list(s):
New Publication
Publication Information
This pull request is to add samples from the following publication(s):
10.1016/j.tube.2022.102181
This is to close #834
Checklist
github-bot
)?/assets/enums
, e.g. material or archive)? If so the corresponding PR is here:If you do not know how to check errors in failed validation checks, expand here
Correction
This PR is for
Reference
This pull request is to correct samples from the following publication(s):
This is to close
Description
The issue is:
Checklist
github-bot
)?