Skip to content

feat(YouTube): Support version 20.12.46 #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2025

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Apr 13, 2025

20.12 fixes a bug in unpatched YT where the video like/dislikes use the wrong font.

@0xrxL
Copy link

0xrxL commented Apr 14, 2025

@LisoUseInAIKyrios Force disable double back to exit stock feature of the app, and leave only the patched way to perform that.

With the automotive layout, the double back to exit works without any fix (there are no ads on homepage), but it's bugged on 20.13+ and sometimes the app is closed also if you are currently watching a video and perform a single back gesture.

I'll do the same on uDrop when I'll can

@MarcaDian
Copy link
Contributor

MarcaDian commented Apr 14, 2025

and sometimes the app is closed also if you are currently watching a video and perform a single back gesture.

I also have this problem when I open Shorts in the regular player and perform single back gesture.

@0xrxL
Copy link

0xrxL commented Apr 14, 2025

and sometimes the app is closed also if you are currently watching a video and perform a single back gesture.

I also have this problem when I open Shorts in the regular player and perform single back gesture.

Yeah, and it's annoying. In any case stock feature can be easily disabled in favor of already existing fix in ReVanced.

@0xrxL
Copy link

0xrxL commented Apr 14, 2025

UPDATE: to disable stock double back to exit, set flag 45385099L to true.

@LisoUseInAIKyrios
Copy link
Contributor Author

It must be an a/b feature because the flag is not on for any of my accounts. If I force the flag on, I can't reproduce any issues.

There are some other flags that might be related but I didn't try forcing them on/off 45414493L, 45359224L

@MarcaDian You can try this branch and see if the back issue is fixed.

@0xrxL
Copy link

0xrxL commented Apr 14, 2025

@LisoUseInAIKyrios It's not always reproducible, it happens sometimes...especially during video watching.

@0xrxL
Copy link

0xrxL commented Apr 14, 2025

@LisoUseInAIKyrios I updated spoof stream clients list too. I added the last Pixel 9 software in the Android VR, and I got opus codec. So idk...decide if could be a good addition.

@LisoUseInAIKyrios
Copy link
Contributor Author

I've been seeing opus audio with Android VR for a while.

@MarcaDian
Copy link
Contributor

MarcaDian commented Apr 14, 2025

I'll try this branch now.

It might be useful, but in versions 20.13-20.15, exiting the program using 2 back gestures sometimes doesn't work for me.

Edit: add a gif to show a problem (not this branch, v22)

Screenrecorder-2025-04-14-16-26-51-605.gif

@MarcaDian
Copy link
Contributor

MarcaDian commented Apr 14, 2025

After I press the back gesture, the program goes to the home screen and continues playing in the background. If I open it again, everything works.

Screenrecorder-2025-04-14-16-15-41-849.gif

PS: GitHub on PC doesn't show video, need convert to gif

@LisoUseInAIKyrios
Copy link
Contributor Author

Then something is missing if this is a fix. I'll revert the change since it's not confirmed to fix.

@cyberboh
Copy link
Contributor

I'll try this branch now.

It might be useful, but in versions 20.13-20.15, exiting the program using 2 back gestures sometimes doesn't work for me.

Edit: add a gif to show a problem (not this branch, v22)

I have this bug also, confirmed.
It is random though.
YouTube version is 20.15 from patcher v22 branch too.

@LisoUseInAIKyrios
Copy link
Contributor Author

Try version 20.12 and see if it is affected.

Could use that target because the font issue is fixed from 20.12+

@0xrxL
Copy link

0xrxL commented Apr 14, 2025

I will try to block the call to destroy the activity. Maybe this will solve the issue.

@cyberboh
Copy link
Contributor

Try version 20.12 and see if it is affected.

Could use that target because the font issue is fixed from 20.12+

After testing 20.12.46 I do not face back gesture bug. So far so good but still need testing it throughly.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube): Support version 20.13.41 feat(YouTube): Support version 20.12.46 Apr 15, 2025
@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Apr 16, 2025

20.13+ has an issue where if a video is closed and the app is then exited (up to a few seconds after), then PiP is activated even though the video player is not open. 20.12 doesn't have the issue.

Otherwise this seems to be stable enough and has less bugs than 20.07

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 703359f into ReVanced:dev Apr 16, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Apr 16, 2025
# [5.21.0-dev.1](v5.20.1...v5.21.0-dev.1) (2025-04-16)

### Features

* **YouTube:** Support version `20.12.46` ([#4779](#4779)) ([703359f](703359f))
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the feat/yt_20_13 branch April 16, 2025 08:30
github-actions bot pushed a commit that referenced this pull request Apr 25, 2025
# [5.21.0](v5.20.1...v5.21.0) (2025-04-25)

### Bug Fixes

* `Hide ADB status` patch ([#4814](#4814)) ([dc89be0](dc89be0))
* **GmsCore Support:** Correct the description to refer to the app being patched ([2bbcf9d](2bbcf9d))
* **Wide search bar:** Fix patching `19.16.39` ([433dbc3](433dbc3))
* **YouTube - Change start page:** Add option to always override start page on app launch ([#4832](#4832)) ([5062e24](5062e24))
* **YouTube - Disable auto captions:** Correctly hide captions with YT 20.12 ([5ecbe82](5ecbe82))
* **YouTube - Hide video action buttons:** Add option to hide 'Ask' button ([#4852](#4852)) ([43bcf5a](43bcf5a))
* **YouTube - Hide video action buttons:** Hide A/B layout buttons ([4db5d3c](4db5d3c))
* **YouTube - Wide search bar:** Do not force phone layout for tablet devices ([#4827](#4827)) ([0cb38f9](0cb38f9))

### Features

* Add `Hide ADB status` patch ([#4585](#4585)) ([1ea8047](1ea8047))
* **X / Twitter:** Support version `10.86.0-release.0` ([#4805](#4805)) ([655b390](655b390))
* **YouTube - Swipe controls:** Add option for vertical progress bar ([#4811](#4811)) ([ebee07e](ebee07e))
* **YouTube:** Support version `20.12.46` ([#4779](#4779)) ([703359f](703359f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants